Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Material ui v4 #758

Merged
merged 5 commits into from
Jul 8, 2020
Merged

Material ui v4 #758

merged 5 commits into from
Jul 8, 2020

Conversation

kestarumper
Copy link
Member

This PR

  • updates @material-ui/core package to the newest (4.9.9 -> 4.11.0) version and drops support for lower versions (^3.0.0 || ^1.2.0)
  • fixes an error that material-ui component starts as an uncontrolled when value prop is undefined

@kestarumper kestarumper added the Type: Feature New features and feature requests label Jul 1, 2020
@kestarumper kestarumper added this to the v3.0 milestone Jul 1, 2020
@kestarumper kestarumper requested review from radekmie and Monteth July 1, 2020 13:23
@kestarumper kestarumper self-assigned this Jul 1, 2020
@codecov
Copy link

codecov bot commented Jul 1, 2020

Codecov Report

Merging #758 into v3 will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##               v3     #758   +/-   ##
=======================================
  Coverage   97.81%   97.81%           
=======================================
  Files         175      175           
  Lines        3389     3390    +1     
  Branches      640      641    +1     
=======================================
+ Hits         3315     3316    +1     
  Misses          8        8           
  Partials       66       66           
Impacted Files Coverage Δ
packages/uniforms-material/src/BoolField.tsx 100.00% <100.00%> (ø)
packages/uniforms-material/src/RadioField.tsx 96.29% <100.00%> (+0.14%) ⬆️
packages/uniforms-material/src/SelectField.tsx 91.37% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0160799...34dd847. Read the comment docs.

packages/uniforms-material/src/BoolField.tsx Outdated Show resolved Hide resolved
packages/uniforms-material/src/BoolField.tsx Outdated Show resolved Hide resolved
packages/uniforms-material/src/SelectField.tsx Outdated Show resolved Hide resolved
packages/uniforms-material/src/RadioField.tsx Outdated Show resolved Hide resolved
@kestarumper kestarumper requested a review from radekmie July 2, 2020 10:30
Co-authored-by: Radosław Miernik <radekmie@gmail.com>
@radekmie radekmie merged commit 32e3a09 into v3 Jul 8, 2020
@radekmie radekmie deleted the material-ui-v4 branch July 8, 2020 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature New features and feature requests
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants