Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

showInlineError for whole form #87

Closed
RSchwan opened this issue Jul 30, 2016 · 3 comments
Closed

showInlineError for whole form #87

RSchwan opened this issue Jul 30, 2016 · 3 comments
Assignees
Labels
Type: Feature New features and feature requests

Comments

@RSchwan
Copy link
Contributor

RSchwan commented Jul 30, 2016

I just have seen this pull request #84 and I think this is a really useful feature.
The only problem I see with it is that you have to add the showInlineError property to all fields manually. I think it would be great if you could set this prop on per example the AutoForm component so that automatically all fields show a inline error.
Of course it would be possible to override it manually on a field.

What do you think?

@radekmie radekmie added the Type: Feature New features and feature requests label Jul 30, 2016
@radekmie radekmie self-assigned this Jul 30, 2016
@radekmie
Copy link
Contributor

Yes, I've even started working on this (locally). At first, I thought about renaming it to inlineErrors, then ensure it is implemented in every package (I'm not sure, how to display it in uniforms-unstyled) and then allow BaseForm to pass this prop down (same as disabled).

@vladejs
Copy link

vladejs commented Sep 4, 2016

@radekmie , Have this been implemented? It doesn't work in my forms either with showInlineErrors nor inlineErrors

@radekmie
Copy link
Contributor

radekmie commented Sep 9, 2016

@vladejs
Sorry for long delay - I was on vacation. No, It's not implemented yet (to be honest, it's only a concept). As of #84, you can use showInlineError on every field in bootstrap3 and bootstrap4 packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature New features and feature requests
Projects
Archived in project
Development

No branches or pull requests

3 participants