Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves typings in a few ways:
.d.ts
files much shorter.tslib
update, thus this PR supersedes Updated tslib version to 2.2.0. #948.createAutoField
andconnectField
..d.ts
files.ConnectFieldOptions
,ConnectedFieldProps<Props, Value>
, andConnectedField<Props, Value
.@internal
and I think that's the way to go - let's mark "actually internal" types with this JSDoc.As a result, multiple
.d.ts
files are much smaller now.uniforms-antd/es5/AutoField.d.ts
before - 2831Buniforms-antd/es5/AutoField.d.ts
after - 432Buniforms-antd/es5/TextField.d.ts
before - 11238Buniforms-antd/es5/TextField.d.ts
after - 358BSurprisingly, an update of TypeScript broke
connectField
inference and forced me to explicitly stateProps
in all cases. It may be a breaking change type-wise but not necessarily, as it may be the case, that:Therefore, I think we can release it as a semver-minor.