Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use unplugin-config #3106

Merged
merged 2 commits into from
Oct 8, 2023
Merged

refactor: use unplugin-config #3106

merged 2 commits into from
Oct 8, 2023

Conversation

kirklin
Copy link

@kirklin kirklin commented Oct 8, 2023

General

✏️ Mark the necessary items without changing the structure of the PR template.

  • Pull request template structure not broken

Type

ℹ️ What types of changes does your code introduce?

👉 Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

ℹ️ Check all checkboxes - this will indicate that you have done everything in accordance with the rules in CONTRIBUTING.

👉 Put an x in the boxes that apply.

  • My code follows the style guidelines of this project
  • Is the code format correct
  • Is the git submission information standard?
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@likui628 likui628 requested a review from jinmao88 October 8, 2023 06:36
@likui628
Copy link
Collaborator

likui628 commented Oct 8, 2023

@jinmao88

@wangjue666
Copy link
Collaborator

@kirklin 打包完后空格消失了
image

如果把 VITE_GLOB_APP_TITLE = Vben Admin2 标题显示正常了,但又出现
image

@kirklin
Copy link
Author

kirklin commented Oct 8, 2023

@kirklin 打包完后空格消失了 image

如果把 VITE_GLOB_APP_TITLE = Vben Admin2 标题显示正常了,但又出现 image

应该是规则不一样的原因,我会自动把空格删除掉,这个我去修一下。

@jinmao88 jinmao88 merged commit a712a8e into vbenjs:main Oct 8, 2023
2 checks passed
@wangjue666
Copy link
Collaborator

@kirklin 如果把 VITE_GLOB_APP_TITLE = Vben Admin2 这个问题还是会出现 Uncaught TypeError: Cannot destructure property 'VITE_GLOB_APP_TITLE' of 'C' as it is undefined 之前vben 是有不少人提过这样问题

wangjue666 added a commit that referenced this pull request Oct 8, 2023
@wangjue666
Copy link
Collaborator

@kirklin 我先将这块回滚了, 修复好你再提个PR吧 :)

@github-actions github-actions bot locked and limited conversation to collaborators Aug 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants