Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(ImageUpload): 根据官方示例设置图片回显格式 #3252

Merged
merged 2 commits into from
Nov 13, 2023
Merged

perf(ImageUpload): 根据官方示例设置图片回显格式 #3252

merged 2 commits into from
Nov 13, 2023

Conversation

zwtvip
Copy link

@zwtvip zwtvip commented Nov 7, 2023

General

✏️ Mark the necessary items without changing the structure of the PR template.

  • Pull request template structure not broken

Type

ℹ️ What types of changes does your code introduce?

👉 Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

ℹ️ Check all checkboxes - this will indicate that you have done everything in accordance with the rules in CONTRIBUTING.

👉 Put an x in the boxes that apply.

  • My code follows the style guidelines of this project
  • Is the code format correct
  • Is the git submission information standard?
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@wangjue666
Copy link
Collaborator

@zwtvip 这样调整,不是比之前更难用了些吗

before:

 defaultValue: [
    'https://zos.alipayobjects.com/rmsportal/jkjgkEfvpUPVyRjUImniVslZfWPnJuuZ.png',
  ],

after:

[
    {
      uid: '-1',
      name: 'image.png',
      status: 'done',
      url: 'https://zos.alipayobjects.com/rmsportal/jkjgkEfvpUPVyRjUImniVslZfWPnJuuZ.png',
    },
  ],

@zwtvip
Copy link
Author

zwtvip commented Nov 8, 2023

我尝试了在正式环境使用,上传完会触发watch监听,导致格式不正确而报错,图片无法回显,所以改了官方格式回显,跟外部解耦

@wangjue666
Copy link
Collaborator

@zwtvip 那不是应该要在watch里面做手脚吗

我尝试了在正式环境使用,上传完会触发watch监听,导致格式不正确而报错,图片无法回显,所以改了官方格式回显,跟外部解耦

@zwtvip
Copy link
Author

zwtvip commented Nov 11, 2023

已优化

@jinmao88 jinmao88 merged commit 2991bb1 into vbenjs:main Nov 13, 2023
2 checks passed
@zwtvip zwtvip deleted the upload branch November 15, 2023 12:57
@github-actions github-actions bot locked and limited conversation to collaborators Aug 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants