Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "feat: table搜索表单值发生改变可以触发reload (#3378)" #3407

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

luchanan
Copy link

This reverts commit 1ca3f7c.

#3378, 之前提交的这个PR, 存在以下问题

  • reload的时候没有带上参数
  • change会覆盖changeEvent事件,导致点搜索无法带上参数

另外发现submitOnChange=true就可以实现值改变的时候触发table重新请求,所以请求回滚代码。

General

✏️ Mark the necessary items without changing the structure of the PR template.

  • Pull request template structure not broken

Type

ℹ️ What types of changes does your code introduce?

👉 Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

ℹ️ Check all checkboxes - this will indicate that you have done everything in accordance with the rules in CONTRIBUTING.

👉 Put an x in the boxes that apply.

  • My code follows the style guidelines of this project
  • Is the code format correct
  • Is the git submission information standard?
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@wangjue666 wangjue666 merged commit 2828ed3 into vbenjs:main Dec 13, 2023
2 checks passed
@luchanan luchanan deleted the fix branch December 13, 2023 10:45
WitMiao pushed a commit to WitMiao/vue-vben-admin that referenced this pull request Dec 17, 2023
@vbenjs vbenjs locked and limited conversation to collaborators Aug 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants