Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(router): the issue of blank page navigation during repair of non-LAYOUT first-level route component #3764

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

cszhjh
Copy link

@cszhjh cszhjh commented Apr 18, 2024

修复一级路由 componentLAYOUT (并且是homePath),当 url 为 http://localhost:5174/#/ 时为空白页

General

✏️ Mark the necessary items without changing the structure of the PR template.

  • Pull request template structure not broken

Type

ℹ️ What types of changes does your code introduce?

👉 Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

ℹ️ Check all checkboxes - this will indicate that you have done everything in accordance with the rules in CONTRIBUTING.

👉 Put an x in the boxes that apply.

  • My code follows the style guidelines of this project
  • Is the code format correct
  • Is the git submission information standard?
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@wangjue666
Copy link
Collaborator

修复一级路由 componentLAYOUT (并且是homePath),当 url 为 http://localhost:5174/#/ 时为空白页

能否录制个视频吗显示这个bug吗?

@cszhjh
Copy link
Author

cszhjh commented Apr 19, 2024

修复一级路由 componentLAYOUT (并且是homePath),当 url 为 http://localhost:5174/#/ 时为空白页

能否录制个视频吗显示这个bug吗?

在BACK模式下触发这个问题,请看GIF图和复现repo
2024-04-19 13 14 48

复现repo

@cszhjh
Copy link
Author

cszhjh commented Apr 19, 2024

dashboard配置如下:

const dashboardRoute = {
  path: '/dashboard',
  name: 'Dashboard',
  component: '/dashboard/analysis/index',
  meta: {
    title: 'routes.dashboard.dashboard',
    icon: 'bx:bx-home',
  }
}

@wangjue666
Copy link
Collaborator

在BACK模式下触发这个问题,请看GIF图和复现repo

了解了!下次可以开个issue, pr链接到issue上~

@wangjue666 wangjue666 merged commit c58c192 into vbenjs:main Apr 19, 2024
2 checks passed
@vbenjs vbenjs locked and limited conversation to collaborators Aug 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants