perf(util): remove handleInputNumberValue #3806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
看下ci 有类型问题 |
okok，已解决 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix:#3805
GeneralPull request template structure not broken
历史遗留问题
当初这个函数的提出是为了解决这个默认值的bug( #3274 )，但是默认值的问题没有彻底解决
直到 #3287 之后才把这个问题大体解决了(定位问题是在isEmpty的使用上面，而跟这个函数没有什么关系)。这时handleInputNumberValue这个函数不仅没发挥到应有的作用，并且导致了input系列组件输入输出类型不一致的问题 。例如输入number，string，其他的数据都会变成string
最近 #3802 pr提过之后，目前的行为是 number变成number，然后其他的都变成string，但是仍然导致了 null 和 undefined等其他类型 会被设置成 string类型。