fix: grid form action locale with keep-alive #5214
Conversation
|
|
Warning There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure. 🔧 eslint
packages/@core/ui-kit/form-ui/src/components/form-actions.vueOops! Something went wrong! :( ESLint: 9.17.0 Error [ERR_MODULE_NOT_FOUND]: Cannot find module '/node_modules/@vben/eslint-config/dist/index.mjs' imported from /eslint.config.mjs WalkthroughThe pull request introduces modifications to button option handling across multiple files in the UI kit and VXE table plugin. The changes focus on enhancing the flexibility of button content by allowing dynamic content generation through function-based approaches. Specifically, the modifications update the Changes
Assessment against linked issues
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Tip CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/@core/ui-kit/form-ui/src/components/form-actions.vue (1)
43-50: Dynamic submit button content is well-structured.
The isFunction check correctly guards against non-function values. This pattern is consistent with the reset logic.If more dynamic transformations are needed later, consider extracting this “handle content” pattern into a small utility function to reduce duplication.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
packages/@core/ui-kit/form-ui/src/components/form-actions.vue(1 hunks)packages/@core/ui-kit/form-ui/src/types.ts(1 hunks)packages/effects/plugins/src/vxe-table/use-vxe-grid.vue(1 hunks)
🔇 Additional comments (5)
packages/@core/ui-kit/form-ui/src/components/form-actions.vue (3)
23-23: Deconstructing the reset button logic is clear.
By extracting resetButtonOptions from rootProps, you simplify referencing it and improve overall readability.
27-34: Ensure function content returns consistent types.
The conditional spread handling of resetButtonOptions.content looks correct. Just verify that any function passed to content always returns a string (and never undefined or another type) to avoid runtime issues.
39-39: Consistent approach for submit button.
Similarly extracting submitButtonOptions from rootProps parallels the logic for resetButtonOptions, aiding maintainability.
packages/@core/ui-kit/form-ui/src/types.ts (1)
313-313: Union type for content enhances flexibility.
Allowing both string and function types for content offers greater adaptability, especially for localized or dynamic labels.
packages/effects/plugins/src/vxe-table/use-vxe-grid.vue (1)
91-91: Leveraging function-based content improves localization.
Switching from a static to a function-based approach for the submit button label is beneficial for supporting live language updates. This is consistent with the code changes in form-actions.vue.
Description
修复表格的搜索表单提交按钮在KeepAlive下无法跟随语言设置切换标题的问题。
fix #5211
Type of change
Please delete options that are not relevant.
pnpm-lock.yamlunless you introduce a new test example.Checklist
pnpm run docs:devcommand.pnpm test.feat:,fix:,perf:,docs:, orchore:.Summary by CodeRabbit
New Features
Bug Fixes