Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AdES digital signature #71

Closed
ioprea opened this issue Apr 27, 2020 · 8 comments
Closed

AdES digital signature #71

ioprea opened this issue Apr 27, 2020 · 8 comments

Comments

@ioprea
Copy link

ioprea commented Apr 27, 2020

Describe the bug and the expected behaviour
I have been trying out the lib, but I am not sure whether it generates PAdES compliant signatures. I have tried validating it here https://ec.europa.eu/cefdigital/DSS/webapp-demo/validation which seems like the only tool for PAdES validation but I have been getting 'The signature/seal is not a valid AdES digital signature!'. I don't know if I am doing something wrong or if that's the expected behaviour.

Is it a bug in signing or in the helpers?
Haven't seen anything similar

To Reproduce
Sign a document using the library, I have tested it on a dummy.pdf nothing special with different certificates. Just upload the original and signed file to the validation platform specified above. It offer detailed information regarding the signature
Screenshot 2020-04-27 at 12 23 20

@vbuch
Copy link
Owner

vbuch commented Apr 27, 2020

True. We have not created AdES with node-signpdf but rather only an ES. AFAIK the only thing you need more is a trusted issuer. But I havent gone through the details of that. Some code changes may be needed if we want to produce PAdES. Someone needs to research this.
I think #70 is about the same issue.

@vbuch
Copy link
Owner

vbuch commented Apr 27, 2020

BTW Reading through the spec, I think the signed documents produced here are PAdES Basic (section 5.1)

@ioprea
Copy link
Author

ioprea commented Apr 28, 2020

Indeed it is PAdES Basic, over the next few weeks I will be looking over generating an AdES signature, it seems like there is only a Java lib that does it, will try to implement it in nodejs.

@kas84
Copy link

kas84 commented May 31, 2020

@ioprea did you manage to do it? What’s the java library that does it?

@agustif
Copy link

agustif commented Jul 24, 2020

Interested on seeing this through, maybe I can contribute? Let me know where you left it of @ioprea if you wish !

@HamidOsouli-zz
Copy link

Same issue here.

@stale
Copy link

stale bot commented Dec 15, 2020

This issue has been automatically marked as stale because it has not had activity in the past 90 days. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Dec 15, 2020
@stale stale bot closed this as completed Dec 25, 2020
@sanchezandoni
Copy link

Hi! Any news on this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants