feat: adds quick action to add module to recently focused group #586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provides the user a quick way to add modules to groups. A new indicator in the top right of the group shows which group is focused, ready to accept gallery modules when double clicked fixes #496
TimPietrusky
approved these changes
Jun 24, 2021
There was a problem hiding this comment.
Tested and works. What is a bit confusing in terms of UX is that when the group is focused, you have both the focus border and the focus indicator. But only the indicator will stay when the group is losing focus. That might be confusing as it's not clear why these are different.
But that is something for a later point in time ;)
2xAA
pushed a commit
that referenced
this pull request
Jun 24, 2021
# [3.17.0](3.16.0...3.17.0) (2021-06-24) ### Bug Fixes * fixes shader gallery preview sizes ([#585](#585)) ([c4e289a](c4e289a)) ### Features * adds quick action to add module to recently focused group ([#586](#586)) ([dca9ea0](dca9ea0)), closes [#496](#496) * adds version number to status bar ([#587](#587)) ([0afd65f](0afd65f)), closes [#581](#581)
|
🎉 This PR is included in version 3.17.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
@TimPietrusky I thought maybe the circle indicator was better than having two focus rings, which might get even more confusing 😅 |
2xAA
pushed a commit
that referenced
this pull request
Jan 7, 2022
# [3.17.0](3.16.0...3.17.0) (2021-06-24) ### Bug Fixes * fixes shader gallery preview sizes ([#585](#585)) ([c4e289a](c4e289a)) ### Features * adds quick action to add module to recently focused group ([#586](#586)) ([dca9ea0](dca9ea0)), closes [#496](#496) * adds version number to status bar ([#587](#587)) ([0afd65f](0afd65f)), closes [#581](#581)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides the user a quick way to add modules to groups. A new indicator in the top right of the group shows which group is focused, ready to accept gallery modules when double clicked
fixes #496