Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(renderers): implement new methods to handle updating and resizing modules #764

Merged
merged 6 commits into from
Sep 20, 2022

Conversation

2xAA
Copy link
Member

@2xAA 2xAA commented Sep 13, 2022

Allows renderers to handle extra data needed for modules which don't need to be on the data attribute.

Be sure to squash, please!

@2xAA 2xAA marked this pull request as ready for review September 13, 2022 21:02
@2xAA 2xAA linked an issue Sep 20, 2022 that may be closed by this pull request
Copy link
Member

@TimPietrusky TimPietrusky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested super hard, now it's perfect <3

@TimPietrusky TimPietrusky merged commit 0000d7a into next Sep 20, 2022
@TimPietrusky TimPietrusky deleted the fix/711/threejs branch September 20, 2022 20:18
2xAA pushed a commit that referenced this pull request Nov 1, 2022
# [3.25.0](3.24.0...3.25.0) (2022-11-01)

### Bug Fixes

* **loading:** get rid of ripple and use static text to remove layout shifts ([#767](#767)) ([0a2f134](0a2f134))
* **menu-bar:** allow opening of any type of file and add default file name ([#774](#774)) ([b1ea89f](b1ea89f))
* **output-window:** sets size on creation of window and removes overflow ([#756](#756)) ([b3df0f6](b3df0f6))
* **renderers:** implement new methods to handle updating and resizing modules ([#764](#764)) ([0000d7a](0000d7a))
* set pipeline default value ([#769](#769)) ([ba46648](ba46648))
* **setup-media:** splits audio and video mediastreams and cleans up UI ([#757](#757)) ([00be42f](00be42f))
* waveform color ([#770](#770)) ([981efaf](981efaf))

### Features

* **group:** add draw to output toggle ([#762](#762)) ([b232b0b](b232b0b))
* **isf-fft:** adds fft into the renderers for use in ISF ([#640](#640)) ([a6a699c](a6a699c))
@2xAA
Copy link
Member Author

2xAA commented Nov 1, 2022

🎉 This PR is included in version 3.25.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@2xAA 2xAA added the released label Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ThreeJS] Preset contains camera + scene
2 participants