Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle potential comms failure when there are handshakes done #78

Open
rtshkmr opened this issue Aug 12, 2024 · 0 comments
Open

Handle potential comms failure when there are handshakes done #78

rtshkmr opened this issue Aug 12, 2024 · 0 comments
Labels
lift.medium expected lift for it is medium. e.g. some unknowns expected priority.low

Comments

@rtshkmr
Copy link
Member

rtshkmr commented Aug 12, 2024

Present Context

Currently, the written module and the media_library module do their respective handshakes, after which the correct voice is loaded.

We now handle for duplicate acks as a result of the way we init the handshakes.

We should account for what happens when the current handshake methodology fails? When to re-init it?

setting as low priority:
it's a very rare edge case that has not been encountered yet.

med lift because it requires a re-init to be done JIT, which means a bunch of extra handlers need to be added since pub-sub is never a sync-process

@rtshkmr rtshkmr added priority.low lift.medium expected lift for it is medium. e.g. some unknowns expected labels Aug 12, 2024
@rtshkmr rtshkmr changed the title Handle Comms Failure in Handshakes done Handle potential comms failure when there are handshakes done Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lift.medium expected lift for it is medium. e.g. some unknowns expected priority.low
Projects
None yet
Development

No branches or pull requests

1 participant