Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update-comment true not working #23

Closed
ricardovanlaarhoven opened this issue Aug 31, 2021 · 7 comments
Closed

update-comment true not working #23

ricardovanlaarhoven opened this issue Aug 31, 2021 · 7 comments

Comments

@ricardovanlaarhoven
Copy link

- name: report coverage based on jest
        uses: vebr/jest-lcov-reporter@v0.2.0
        with:
          github-token: ${{ secrets.GITHUB_TOKEN }}
          update-comment: true

I've changed update-comment a while ago from false into true and the comments even from new PR's are still not updated.

Perhaps this is the same (but opposite) issue as #21

@ricardovanlaarhoven
Copy link
Author

Warning: Unexpected input(s) 'update-comment', valid inputs are ['github-token', 'lcov-file', 'lcov-base']

@ricardovanlaarhoven
Copy link
Author

The latest release github action failed, that release included this feature. Please take a look into that.
i'd love to help but i cant check the logs or run the command

@alexjfno1 Perhaps you could take a look?

@alexjfno1
Copy link
Contributor

@ricardovanlaarhoven I'll update and see if I can reproduce

@ricardovanlaarhoven
Copy link
Author

#21 (comment)
The weird thing is that your comment there would mean that it's really weird that my action is always creating a new comment
and that message: Unexpected input(s) 'update-comment'

@alexjfno1
Copy link
Contributor

@ricardovanlaarhoven the action will always create a comment weather you specify update-comment or not. update-comment just means that if you push another commit to the PR it'll replace the existing comment with an updated one instead of creating a new one.

@alexjfno1
Copy link
Contributor

alexjfno1 commented Oct 6, 2021

@ricardovanlaarhoven can I just check that you're on the latest version?

uses: vebr/jest-lcov-reporter@v0.2.1

@ricardovanlaarhoven
Copy link
Author

I was using 0.2.0, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants