Fix broken video compression due to NPE in library #4353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Library issue: https://github.com/natario1/Transcoder/issues/154 Possibly fixes element-hq#4337 Also add some logging for failures.
SpiritCroc
force-pushed
the
video-compression
branch
from
4fef2e7 to
076820b
Compare
bmarty
reviewed
Oct 27, 2021
...android/src/main/java/org/matrix/android/sdk/internal/session/content/UploadContentWorker.kt
Outdated
Show resolved
Hide resolved
ouchadam
approved these changes
Nov 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Library issue: https://github.com/natario1/Transcoder/issues/154
Possibly fixes
#4337
Also add some logging for failures.
Signed-off-by: Tobias Büttner dev@spiritcroc.de
Pull Request Checklist