Voice recording UI state in ViewModel #4515

ouchadam · 2021-11-18T17:38:23Z

Inverts the VoiceMessageRecorderView update flow so that TextComposerViewModel controls the RecordingUiState

Allows the dragging to cancel or lock mid way, the current behaviour forces whichever action the user starts dragging towards
Fixes a small UI quirk where the recording layout would jump, caused by aligning to the mic button rather than the send button
Fixes the dragging becoming inverted if dragging past the initial touch position
Tentatively fixes Unable to record a voice message after pressing the microphone icon a few times #4400 (I've not been able to reproduce on this branch at least)

Next step is to port the Voice draft to the SDK #4237

CANCEL	LOCK SEND	LOCK DELETE

CANCEL OR LOCK	HOLDING

- creates a display entry point which will be called externally

- fixes other quirks caused by porting to the inverted display logic

… the margin, fixes the layout jumping when the mic button switches to a send

… displaying

…ing ended

…pler

…the file straight away

github-actions · 2021-11-18T18:08:27Z

Unit Test Results

  66 files ±0   66 suites ±0 1m 6s ⏱️ -6s
135 tests ±0 135 ✔️ ±0 0 💤 ±0 0 ❌ ±0
418 runs ±0 418 ✔️ ±0 0 💤 ±0 0 ❌ ±0

Results for commit 7d0d105. ± Comparison against base commit d00277a.

♻️ This comment has been updated with latest results.

DoM1niC · 2021-11-18T18:26:29Z

Nice One :) can you try to fix the multiple send issue if you send more than one Voice Message the following Messages will Stuck and can't be resended.

Update
Ahhh sry I see this will important for Draft SDK Stuff #4237

ouchadam · 2021-11-18T18:30:30Z

@DoM1niC I'll have a look since I'm in the area!

ouchadam · 2021-11-19T10:43:16Z

vector/src/main/java/im/vector/app/features/home/room/detail/composer/TextComposerViewState.kt

 ) : MavericksState {

+    val isVoiceRecording = when (voiceRecordingUiState) {


the isRecording and isIdle states are inferred from the UI state

ouchadam · 2021-11-19T10:44:17Z

...or/src/main/java/im/vector/app/features/home/room/detail/composer/voice/VoiceMessageViews.kt

+import im.vector.app.features.home.room.detail.composer.voice.VoiceMessageRecorderView.RecordingUiState
+import im.vector.app.features.home.room.detail.timeline.helper.VoiceMessagePlaybackTracker
+
+class VoiceMessageViews(


all of the android widget interactions have been extracted into this delegate, to help keep the VoiceMessageRecorderView as simple as possible

…which actions should be handled in each layer

ouchadam · 2021-11-19T14:54:08Z

changelog.d/4515.misc

@@ -0,0 +1 @@
+Voice recording mic button refactor with small animation tweaks in preparation for voice drafts


wasn't 100% sure if the change log entry was needed as this is mostly refactoring (same as #4523)

Always OK to have a changelog, if something goes wrong (I hope no!), we keep quickly see in the change history what have been done.

bmarty

LGTM, small remark on naming.
Did not test, will rather test after change on draft handling 👍

bmarty · 2021-11-19T14:54:56Z

...main/java/im/vector/app/features/home/room/detail/composer/voice/VoiceMessageRecorderView.kt

+        voiceMessageViews.renderVisibilityChanged(parentChanged, visibility)
+    }
+
+    fun display(recordingState: RecordingUiState) {


Nit: in the codebase those methods are named render()

ah, will update in the other PR

bmarty · 2021-11-19T14:57:11Z

changelog.d/4515.misc

@@ -0,0 +1 @@
+Voice recording mic button refactor with small animation tweaks in preparation for voice drafts


Always OK to have a changelog, if something goes wrong (I hope no!), we keep quickly see in the change history what have been done.

bmarty · 2021-11-19T14:59:43Z

Stop the CI, due to add changelog entry. Previous commit was green (sort of)

ouchadam added 15 commits November 18, 2021 14:15

inverting and splitting the voice message view into logic and views

f0ef9e9

- creates a display entry point which will be called externally

lifting voice display logic out of the view and to the layer above

f269055

lifting current recording state out of the view

40d762c

moving the recording ui state to the textcomposer view model and state

2ad121e

replacing chained ifs with when

e895dbd

allows locking and cancelling to occur after choosing either option

9ae03b7

- fixes other quirks caused by porting to the inverted display logic

aligning the locked recording view to the send message button without…

be685bc

… the margin, fixes the layout jumping when the mic button switches to a send

updating the state rather than calling display directly

dfc67b8

removing no longer needed cancelled status check

bf37437

renaming display function as its updating state, rather than directly…

734e7df

… displaying

updating voice view interface method names for consistency

c5746a5

adding sending of voice message on send pressed

16ca7d5

clarifying why we do nothing when the state is locked on voice record…

4dbb150

…ing ended

separating the cancelled and ended events to make the consumption sim…

1afc1b5

…pler

removing no longer needed message delete on animation end, we delete …

7d262eb

…the file straight away

ouchadam commented Nov 19, 2021

View reviewed changes

separating the drag state from the main UI state in order to clarify …

331bcbf

…which actions should be handled in each layer

ouchadam mentioned this pull request Nov 19, 2021

Moving voice logic to the MessageComposer #4523

Merged

adding changelog entry

7d0d105

ouchadam commented Nov 19, 2021

View reviewed changes

bmarty approved these changes Nov 19, 2021

View reviewed changes

bmarty merged commit 35f9bef into develop Nov 19, 2021

bmarty deleted the feature/adm/voice-state branch November 19, 2021 14:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Voice recording UI state in ViewModel #4515

Voice recording UI state in ViewModel #4515

ouchadam commented Nov 18, 2021

github-actions bot commented Nov 18, 2021 •

edited

Loading

DoM1niC commented Nov 18, 2021 •

edited

Loading

ouchadam commented Nov 18, 2021

ouchadam Nov 19, 2021

ouchadam Nov 19, 2021

ouchadam Nov 19, 2021

bmarty Nov 19, 2021

bmarty left a comment

bmarty Nov 19, 2021

ouchadam Nov 19, 2021

bmarty Nov 19, 2021

bmarty commented Nov 19, 2021

		) : MavericksState {

		val isVoiceRecording = when (voiceRecordingUiState) {

		@@ -0,0 +1 @@
		Voice recording mic button refactor with small animation tweaks in preparation for voice drafts

Voice recording UI state in ViewModel #4515

Voice recording UI state in ViewModel #4515

Conversation

ouchadam commented Nov 18, 2021

github-actions bot commented Nov 18, 2021 • edited Loading

Unit Test Results

DoM1niC commented Nov 18, 2021 • edited Loading

ouchadam commented Nov 18, 2021

ouchadam Nov 19, 2021

Choose a reason for hiding this comment

ouchadam Nov 19, 2021

Choose a reason for hiding this comment

ouchadam Nov 19, 2021

Choose a reason for hiding this comment

bmarty Nov 19, 2021

Choose a reason for hiding this comment

bmarty left a comment

Choose a reason for hiding this comment

bmarty Nov 19, 2021

Choose a reason for hiding this comment

ouchadam Nov 19, 2021

Choose a reason for hiding this comment

bmarty Nov 19, 2021

Choose a reason for hiding this comment

bmarty commented Nov 19, 2021

github-actions bot commented Nov 18, 2021 •

edited

Loading

DoM1niC commented Nov 18, 2021 •

edited

Loading