Fixes myroomnick changing Display Name #5618

ericdecanini · 2022-03-23T17:44:40Z

Type of change

Feature
Bugfix
Technical
Other :

Content

Removes a user entity update when changing your nickname for a single room using the command /myroomnick

Motivation and context

When entering the above command to change the nickname, it updates both the Room Member Entity and the User Entity. It's clear why the Room Member Entity update needs to be made (this actually updates the nickname of that room member), but it's very unclear if the User Entity update is needed at all. This being updated is the source of this bug.

Additionally, changing your nickname in the room changed your display name across the app. You would even see this reflected beside your avatar in the navigation drawer.

Screenshots / GIFs

After updating your nickname in a room, you would get these results:

Before	After

Tests

In any room type the command /myRoomNick [name] to change your nickname for that room
Send a message in the room and see that your nickname in that room is successfully changed
See that your display name on the navigation drawer is as normal and not your newly set room nickname
On another account, create a new room and go to the invite page and search for your account that set the nickname in a room. See that the display name is as normal and not the previously set room nickname

Tested devices

Physical
Emulator
OS version(s): Android 10, 12

Checklist

Changes has been tested on an Android device or Android emulator with API 21
UI change has been tested on both light and dark themes
Accessibility has been taken into account. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#accessibility
Pull request is based on the develop branch
Pull request includes a new file under ./changelog.d. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#changelog
Pull request includes screenshots or videos if containing UI changes
Pull request includes a sign off
You've made a self review of your PR
If you have modified the screen flow, or added new screens to the application, you have updated the test UiAllScreensSanityTest.allScreensTest()

ericdecanini · 2022-03-23T17:46:26Z

.../main/java/org/matrix/android/sdk/internal/session/room/membership/RoomMemberEventHandler.kt

-        if (roomMember.membership.isActive()) {
-            val userEntity = UserEntityFactory.create(userId, roomMember)
-            realm.insertOrUpdate(userEntity)
-        }


@ganfra was there any purpose to this being here?

Yes, this is the way to have local User created from RoomMember state event. If you remove this, we'll loose the avatar/display name of lots of users (which is the same than a RoomMember but outside the context of a room.)
If we remove this, we should take care of fetching profile of users everywhere, which is not that great...

Ahh I see now

github-actions · 2022-03-23T18:37:15Z

Unit Test Results

114 files +  4 114 suites +4 1m 28s ⏱️ +13s
201 tests +  6 201 ✔️ +  6 0 💤 ±0 0 ❌ ±0
674 runs +24 674 ✔️ +24 0 💤 ±0 0 ❌ ±0

Results for commit 8b80cf0. ± Comparison against base commit 72bd398.

♻️ This comment has been updated with latest results.

ganfra

This will fix this case, but will break others, see my comment

…cally if its not a display name change

ericdecanini · 2022-03-30T15:44:40Z

.../main/java/org/matrix/android/sdk/internal/session/room/membership/RoomMemberEventHandler.kt

+        val previousDisplayName = prevContent?.get("displayname")
+        val shouldLocallySaveUser = roomMember.membership.isActive()
+                && (previousDisplayName == null || previousDisplayName == roomMember.displayName)
+
+        if (shouldLocallySaveUser) {
+            saveUserLocally(realm, userId, roomMember)
        }


@ganfra I think this should fix the bug whilst keeping previous functionality intact

ganfra · 2022-03-31T08:51:56Z

So the idea now, is to try fetching profile when having incremental sync using the SyncResponsePostTreatmentAggregator to track userIds to fetch.
In practice, we have 2 cases:

InitialSync: just save the RoomMember content into the UserEntity, except for our own userId (as it already have a fetched profile)
IncrementalSync: check if avatar/displayName of the RoomMember is different from the avatar/DisplayName of the UserEntity. If yes, add this userId to the SyncResponsePostTreatmentAggregator. Then at the end of the sync, you can fetch all the profiles from the aggregator.

ganfra

Some remarks

ganfra · 2022-04-01T16:55:17Z

.../main/java/org/matrix/android/sdk/internal/session/room/membership/RoomMemberEventHandler.kt

-               aggregator: SyncResponsePostTreatmentAggregator? = null): Boolean {
+    fun handleInitialSync(realm: Realm,
+                          roomId: String,
+                          currentUserId: String,


This is already injected on constructor (myUserId)

👁️👄👁️

ganfra · 2022-04-01T17:00:47Z

.../main/java/org/matrix/android/sdk/internal/session/room/membership/RoomMemberEventHandler.kt

+                                  roomMember: RoomMemberContent,
+                                  aggregator: SyncResponsePostTreatmentAggregator?): Boolean {
+        if (currentUserId != eventUserId) {
+            saveRoomMemberEntityLocally(realm, roomId, eventUserId, roomMember)


Always save RoomMember even if its our userId, but don't save User

ganfra · 2022-04-01T17:02:18Z

...trix/android/sdk/internal/session/sync/handler/SyncResponsePostTreatmentAggregatorHandler.kt

+
+        MatrixItem.UserItem(
+                id = it,
+                displayName = profileJson[ProfileService.DISPLAY_NAME_KEY] as? String,


Create a method to reuse these json keys as it's used in several places

ganfra

Ok looks like it's ok now, thanks for this! (haven't tested)

ganfra · 2022-04-06T16:37:57Z

Just fix the conflict and build failing

…display-name # Conflicts: # vector/src/main/java/im/vector/app/features/roommemberprofile/RoomMemberProfileViewModel.kt # vector/src/main/java/im/vector/app/features/userdirectory/UserListViewModel.kt

bmarty

I think this PR will fix the issue. Thanks!
Some remarks on the form.

bmarty · 2022-04-07T14:36:14Z

matrix-sdk-android/src/main/java/org/matrix/android/sdk/api/util/MatrixItem.kt

        init {
            if (BuildConfig.DEBUG) checkId()
        }

        override fun updateAvatar(newAvatar: String?) = copy(avatarUrl = newAvatar)
+
+        companion object {
+            fun fromJson(userId: String, profileJson: JsonDict) = UserItem(


I would prefer that this does not exist.

You can use instead User.fromJson(...).toMatrixItem()

But MatrixItem is more something that the SDK expose to the app, to be used by the UI. The SDK should not use MatrixItem internally. You should use User instead.

bmarty · 2022-04-07T14:42:57Z

...src/main/java/org/matrix/android/sdk/internal/session/room/membership/LoadRoomMembersTask.kt

@@ -123,7 +123,7 @@ internal class DefaultLoadRoomMembersTask @Inject constructor(
                    eventId = roomMemberEvent.eventId
                    root = eventEntity
                }
-                roomMemberEventHandler.handle(realm, roomId, roomMemberEvent)
+                roomMemberEventHandler.handleIncrementalSync(realm, roomId, roomMemberEvent)


Is it possible that we just add a param isInitialSync: Boolean to the existing handle method instead?
I prefer to have only one handle method in the ...Handler class.
Internally it can be deferred to 2 different methods.

I'm generally not a fan of passing boolean flags as the argument here is if you need to pass a boolean that changes the actions of the functions, you may as well make it another function which should be kept as small as possible (again, from Uncle Bob's Clean Code)

But tbh in this case I'm not too bothered either way. I'll make the changes!

bmarty · 2022-04-07T14:43:53Z

.../main/java/org/matrix/android/sdk/internal/session/room/membership/RoomMemberEventHandler.kt

-               aggregator: SyncResponsePostTreatmentAggregator? = null): Boolean {
-        if (roomMember == null) {
-            return false
+    private fun handleInitialSync(realm: Realm,


Having two methods with the same name, one public, one private is not ideal to me.
That's also a reason to keep only one public handle method.

bmarty · 2022-04-07T14:46:02Z

...trix/android/sdk/internal/session/sync/handler/SyncResponsePostTreatmentAggregatorHandler.kt

-    suspend fun handle(synResHaResponsePostTreatmentAggregator: SyncResponsePostTreatmentAggregator) {
-        cleanupEphemeralFiles(synResHaResponsePostTreatmentAggregator.ephemeralFilesToDelete)
-        updateDirectUserIds(synResHaResponsePostTreatmentAggregator.directChatsToCheck)
+    suspend fun handle(aggregator: SyncResponsePostTreatmentAggregator) {


Thanks for having renamed this parameter which was quite typoed :)

bmarty · 2022-04-07T14:46:52Z

...trix/android/sdk/internal/session/sync/handler/SyncResponsePostTreatmentAggregatorHandler.kt

+
+    private suspend fun fetchUsers(usersToFetch: MutableList<String>) = usersToFetch.map {
+        val profileJson = profileService.getProfile(it)
+        MatrixItem.UserItem.fromJson(it, profileJson)


Better to use User.fromJson(it, profileJson) here. (see my other remark)

bmarty · 2022-04-07T14:47:31Z

...d/src/main/java/org/matrix/android/sdk/internal/session/sync/handler/room/RoomSyncHandler.kt

@@ -206,7 +206,7 @@ internal class RoomSyncHandler @Inject constructor(private val readReceiptHandle
                                         insertType: EventInsertType,
                                         syncLocalTimestampMillis: Long,
                                         aggregator: SyncResponsePostTreatmentAggregator): RoomEntity {
-        Timber.v("Handle join sync for room $roomId")


This comment is useful when debugging sync request. Can you restore it please?

bmarty · 2022-04-07T14:48:11Z

...d/src/main/java/org/matrix/android/sdk/internal/session/sync/handler/room/RoomSyncHandler.kt

+                    roomMemberEventHandler.handleInitialSync(realm, roomId, event, aggregator)
+                } else {
+                    roomMemberEventHandler.handleIncrementalSync(realm, roomId, event, aggregator)
+                }


This code, and the similar occurence, will be much simpler with an extra parameter (see my other remark)

bmarty · 2022-04-07T14:49:45Z

...sdk-android/src/main/java/org/matrix/android/sdk/internal/session/user/DefaultUserService.kt

-                    data[ProfileService.DISPLAY_NAME_KEY] as? String,
-                    data[ProfileService.AVATAR_URL_KEY] as? String)
-        }
+    override suspend fun resolveUser(userId: String) = getUser(userId) ?: run {


When reading the code in GitHub, it's far better to keep explicit type : User {
Short fun form with = should be reserved for very small functions.

bmarty · 2022-04-07T14:51:40Z

vector/src/main/java/im/vector/app/features/roommemberprofile/RoomMemberProfileViewModel.kt

-                        )
-                    }
+            session.getProfile(initialState.userId)
+                    .let { MatrixItem.UserItem.fromJson(initialState.userId, it) }


So we will have:

session.getProfile(initialState.userId) .let { User.fromJson(initialState.userId, it) } .toMatrixItem()

bmarty

Thanks for the update. One last remark.

bmarty · 2022-04-08T07:53:07Z

...trix/android/sdk/internal/session/sync/handler/SyncResponsePostTreatmentAggregatorHandler.kt

@@ -92,6 +94,6 @@ internal class SyncResponsePostTreatmentAggregatorHandler @Inject constructor(

    private suspend fun fetchUsers(usersToFetch: MutableList<String>) = usersToFetch.map {
        val profileJson = profileService.getProfile(it)
-        MatrixItem.UserItem.fromJson(it, profileJson)
+        User.fromJson(it, profileJson).toMatrixItem()


As I said, we should not use MatrixItem internally.
Can you change to:

User.fromJson(it, profileJson)

update the code to make it compile and remove UserEntityFactory.create(userItem: MatrixItem.UserItem): UserEntity

Thanks!

Ahh I see what you mean! Sorry I misunderstood the first time. Changes pushed

bmarty · 2022-04-08T07:56:11Z

...trix/android/sdk/internal/session/sync/handler/SyncResponsePostTreatmentAggregatorHandler.kt

+    private suspend fun fetchAndUpdateUsers(usersToFetch: MutableList<String>) {
+        val userProfiles = fetchUsers(usersToFetch)
+        userProfiles.forEach { saveUserLocally(monarchy, it) }
+        usersToFetch.clear()


This is probably not necessary to clear the list.

If we don't though, wouldn't we keep fetching the same users even when we don't need to fetch them anymore? I think it could increase bandwith and performance usage the longer the app is kept on

Nope. A brand new SyncResponsePostTreatmentAggregator is created for each sync request. See https://github.com/vector-im/element-android/blob/develop/matrix-sdk-android/src/main/java/org/matrix/android/sdk/internal/session/sync/SyncResponseHandler.kt#L103

usersToFetch parameter could probably be of type List (instead of MutableList), like for the other methods

Ahhh this wasn't clear to me at first. Changes pushed

bmarty

Sorry, I have further remarks for you.

bmarty · 2022-04-13T12:02:34Z

...trix/android/sdk/internal/session/sync/handler/SyncResponsePostTreatmentAggregatorHandler.kt

+        User.fromJson(it, profileJson)
+    }
+
+    private fun saveUserLocally(monarchy: Monarchy, user: User) {


monarchy is a class member, there is no need to add it as a method parameter.

istg i'm actually blind

bmarty · 2022-04-13T12:10:25Z

...trix/android/sdk/internal/session/sync/handler/SyncResponsePostTreatmentAggregatorHandler.kt

 import org.matrix.android.sdk.internal.session.user.accountdata.DirectChatsHelper
 import org.matrix.android.sdk.internal.session.user.accountdata.UpdateUserAccountDataTask
 import javax.inject.Inject

 internal class SyncResponsePostTreatmentAggregatorHandler @Inject constructor(
        private val directChatsHelper: DirectChatsHelper,
        private val ephemeralTemporaryStore: RoomSyncEphemeralTemporaryStore,
-        private val updateUserAccountDataTask: UpdateUserAccountDataTask
+        private val updateUserAccountDataTask: UpdateUserAccountDataTask,
+        private val profileService: ProfileService,


You should not inject Service in SDK classes. Services are meant to be used by the client app.
Instead you can inject getProfileInfoTask in this case.

bmarty · 2022-04-13T12:15:42Z

...trix/android/sdk/internal/session/sync/handler/SyncResponsePostTreatmentAggregatorHandler.kt

+        monarchy.doWithRealm {
+            it.insertOrUpdate(userEntity)
+        }
+    }


It's good to split code into several smaller methods, but it's maybe harder to read in this particular case.

What about replacing those 3 methods with a single one:

private suspend fun fetchAndUpdateUsers(usersToFetch: List<String>) { usersToFetch .map { userId -> val profileJson = profileService.getProfile(userId) User.fromJson(userId, profileJson) } .map { user -> UserEntityFactory.create(user) } .let { userEntities -> monarchy.doWithRealm { it.insertOrUpdate(userEntities) } } }

Also has the advantage to do on single Realm transaction instead of N transactions with your code.

WDYT?

I personally prefer it split. The advantage is you can get the whole context of the action from the first method, and only if you're concerned about the details of the implementation do you need to read through the bottom methods.

I agree with making it a single Realm transaction though. I'll push changes to make this happen

Your latest implementation is better, thanks. Maybe just skip the transaction if the list is empty, which will be the case nearly all the time, or in case of error when fetching the profile.

bmarty · 2022-04-13T12:17:24Z

...trix/android/sdk/internal/session/sync/handler/SyncResponsePostTreatmentAggregatorHandler.kt

+    }
+
+    private suspend fun fetchUsers(usersToFetch: List<String>) = usersToFetch.map {
+        val profileJson = profileService.getProfile(it)


What will happen if the request fails for any reason, such as no network? I think it will crash the app. Maybe protect by using tryOrNull. We will just ignore updating user in that case, this is not a big deal I think.

A very good point

bmarty

Thanks for the update, more remarks, we will finish it one day!

bmarty · 2022-04-13T13:50:36Z

.../main/java/org/matrix/android/sdk/internal/session/room/membership/RoomMemberEventHandler.kt

-        val roomMember = event.getFixedRoomMemberContent()
-        return handle(realm, roomId, userId, roomMember, aggregator)
+        val roomMember = event.getFixedRoomMemberContent() ?: return false
+        val eventUserId = event.stateKey ?: return false


Why those 2 lines of code have been reordered? I think it's better to restore the original order since it's faster to first check for the stateKey.

bmarty · 2022-04-13T13:52:01Z

...ain/java/org/matrix/android/sdk/internal/session/sync/SyncResponsePostTreatmentAggregator.kt

@@ -22,4 +22,7 @@ internal class SyncResponsePostTreatmentAggregator {

    // Map of roomId to directUserId
    val directChatsToCheck = mutableMapOf<String, String>()
+
+    // List of userIds to fetch and update at the end of incremental syncs
+    val userIdsToFetch = mutableListOf<String>()


Thanks for the renaming :)

bmarty · 2022-04-13T13:53:18Z

...trix/android/sdk/internal/session/sync/handler/SyncResponsePostTreatmentAggregatorHandler.kt

+
+    private suspend fun fetchUsers(userIdsToFetch: List<String>) = tryOrNull {
+        userIdsToFetch.map {
+            val profileJson = getProfileInfoTask.execute(GetProfileInfoTask.Params(it))


I would have put the tryOrNull just on this line to avoid skipping all the treatment in the case of only one request is failing. You can then use mapNotNull to filter out the errors.

bmarty · 2022-04-13T13:55:06Z

...trix/android/sdk/internal/session/sync/handler/SyncResponsePostTreatmentAggregatorHandler.kt

+        monarchy.doWithRealm {
+            it.insertOrUpdate(userEntity)
+        }
+    }


Your latest implementation is better, thanks. Maybe just skip the transaction if the list is empty, which will be the case nearly all the time, or in case of error when fetching the profile.

bmarty

Latest remarks?

bmarty · 2022-04-13T14:18:42Z

.../main/java/org/matrix/android/sdk/internal/session/room/membership/RoomMemberEventHandler.kt

+                                      prevContent: Map<String, Any>?,
+                                      aggregator: SyncResponsePostTreatmentAggregator?): Boolean {
+        val previousDisplayName = prevContent?.get("displayname")
+        val previousAvatar = prevContent?.get("avatar_url")


Maybe add as? String on those 2 lines, so isDifferentFrom can just be removed and replaced by !=, WDYT?

bmarty · 2022-04-13T14:21:25Z

.../main/java/org/matrix/android/sdk/internal/session/room/membership/RoomMemberEventHandler.kt

+                                      roomId: String,
+                                      eventUserId: String,
+                                      roomMember: RoomMemberContent,
+                                      prevContent: Map<String, Any>?,


Could be of type Content?

bmarty · 2022-04-13T14:21:49Z

.../main/java/org/matrix/android/sdk/internal/session/room/membership/RoomMemberEventHandler.kt

-        return RoomMemberSummaryEntity.where(realm, roomId, userId).findFirst()?.userPresenceEntity
+        if (previousDisplayName.isDifferentFrom(roomMember.displayName) ||
+                previousAvatar.isDifferentFrom(roomMember.avatarUrl)) {
+            aggregator?.userIdsToFetch?.add(eventUserId)


If aggregator is null, there is no need to do all this treatment, maybe replace by:

if (aggregator != null) { val previousDisplayName = prevContent?.get("displayname") as? String val previousAvatar = prevContent?.get("avatar_url") as? String if (previousDisplayName != roomMember.displayName || previousAvatar != roomMember.avatarUrl) { aggregator.userIdsToFetch.add(eventUserId) } }

I tested this and it does work!

bmarty · 2022-04-13T14:22:11Z

.../main/java/org/matrix/android/sdk/internal/session/room/membership/RoomMemberEventHandler.kt

+
+    private fun Any?.isDifferentFrom(value: Any?) = when {
+        this == null || this == value -> false
+        else                          -> true


Can be removed

bmarty

Latest remark I think. Can you squash all the commits and force push?

bmarty · 2022-04-13T15:40:26Z

...d/src/main/java/org/matrix/android/sdk/internal/session/sync/handler/room/RoomSyncHandler.kt

@@ -282,7 +283,7 @@ internal class RoomSyncHandler @Inject constructor(private val readReceiptHandle
                                  roomSync: InvitedRoomSync,
                                  insertType: EventInsertType,
                                  syncLocalTimestampMillis: Long): RoomEntity {
-        Timber.v("Handle invited sync for room $roomId")


Ah I miss that at the previous review. Same remark:
This comment is useful when debugging sync request. Can you restore it please?

bmarty

Approved!
Could be nice to squash all the commits to avoid polluting the git history with all the little change / revert. A "squash and merge" can also be done.
Thanks!

Removes user entity change during room nickname change

bbfefbf

ericdecanini requested a review from ganfra March 23, 2022 17:45

ericdecanini commented Mar 23, 2022

View reviewed changes

ericdecanini changed the title ~~Fixes myRoomNick changing Display Name~~ Fixes myroomnick changing Display Name Mar 23, 2022

ericdecanini added the PR-Small PR with less than 20 updated lines label Mar 23, 2022

Adds changelog file

4c1e651

ganfra requested changes Mar 29, 2022

View reviewed changes

Refactors RoomMemberEventHandler with change to only save the user lo…

927eeb3

…cally if its not a display name change

ericdecanini commented Mar 30, 2022

View reviewed changes

ericdecanini requested a review from ganfra March 30, 2022 15:45

Fixes lint error

0200f48

ericdecanini added 2 commits March 31, 2022 17:35

Uses aggregator to handle room name change events

6c1f6dc

Adds missing room member update call during incremental syncs

7f64c62

ganfra requested changes Apr 1, 2022

View reviewed changes

Improves code reuse and readability

25ca684

ericdecanini requested a review from ganfra April 6, 2022 06:48

ericdecanini removed the PR-Small PR with less than 20 updated lines label Apr 6, 2022

ganfra approved these changes Apr 6, 2022

View reviewed changes

ericdecanini added 2 commits April 7, 2022 10:02

Merge remote-tracking branch 'origin/develop' into bugfix/eric/wrong-…

c650843

…display-name # Conflicts: # vector/src/main/java/im/vector/app/features/roommemberprofile/RoomMemberProfileViewModel.kt # vector/src/main/java/im/vector/app/features/userdirectory/UserListViewModel.kt

Fixes errors in RoomSyncHandler

981d157

bmarty requested changes Apr 7, 2022

View reviewed changes

ericdecanini added 5 commits April 7, 2022 16:05

Replaces MatrixItem fromJson with User.toMatrixItem

c1b1386

Combines public initial and incremental handle sync methods into one

6c3c309

Improves code readability

304e2f1

Removes unneeded method

669af4d

Fixes import error

4465525

ericdecanini requested a review from bmarty April 7, 2022 16:13

Removes unused import

de8cc07

bmarty requested changes Apr 8, 2022

View reviewed changes

bmarty reviewed Apr 8, 2022

View reviewed changes

Removes usage of MatrixItem.UserItem internally

b88eaf1

ericdecanini requested a review from bmarty April 8, 2022 10:16

Removes clearing usersToFetch in aggregator

e80386b

bmarty requested changes Apr 13, 2022

View reviewed changes

Adds exception safety to fetch users and makes it a single transaction

f103d46

ericdecanini requested a review from bmarty April 13, 2022 13:27

bmarty requested changes Apr 13, 2022

View reviewed changes

ericdecanini added 4 commits April 13, 2022 16:04

Changes null check timing when fetching users

5d5a06b

Reorders val declaration of eventUserId and roomMember

2337b18

Adds empty check before saving user entities

8964b55

Reformats not empty check

5f949e9

bmarty reviewed Apr 13, 2022

View reviewed changes

Simplifies handleIncrementalSync logic

dd988d0

bmarty reviewed Apr 13, 2022

View reviewed changes

Restores debug log

8b80cf0

bmarty approved these changes Apr 13, 2022

View reviewed changes

ericdecanini merged commit 9b7e94e into develop Apr 13, 2022

ericdecanini deleted the bugfix/eric/wrong-display-name branch April 13, 2022 16:35

ericdecanini mentioned this pull request Apr 20, 2022

Replaces monarchy.doWithRealm with monarchy.awaitTransaction #5792

Merged

15 tasks

This was referenced Jun 1, 2022

myroomnick changes the Global name #1715

Closed

When user updates their avatar, Element tells that the user has joined the room #1080

Closed

Fixes myroomnick changing Display Name #5618

Fixes myroomnick changing Display Name #5618

Conversation

ericdecanini commented Mar 23, 2022 • edited Loading

Type of change

Content

Motivation and context

Screenshots / GIFs

Tests

Tested devices

Checklist

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Mar 23, 2022 • edited Loading

Unit Test Results

ganfra left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ganfra commented Mar 31, 2022

ganfra left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ganfra left a comment

Choose a reason for hiding this comment

ganfra commented Apr 6, 2022

bmarty left a comment

Choose a reason for hiding this comment

bmarty Apr 7, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bmarty left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ericdecanini Apr 8, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bmarty Apr 12, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bmarty left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ericdecanini Apr 13, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bmarty left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bmarty left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bmarty left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ericdecanini commented Mar 23, 2022 •

edited

Loading

github-actions bot commented Mar 23, 2022 •

edited

Loading

bmarty Apr 7, 2022 •

edited

Loading

ericdecanini Apr 8, 2022 •

edited

Loading

bmarty Apr 12, 2022 •

edited

Loading

ericdecanini Apr 13, 2022 •

edited

Loading