-
Notifications
You must be signed in to change notification settings - Fork 749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement a more scoped API to the Session
interface
#5816
Conversation
7c54d97
to
10434e7
Compare
10434e7
to
4af883f
Compare
I don't understand purpose of session in this implementation: why would I inject |
We can discuss and make some changes in the future when we will be supporting multi-account. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for explanation
Type of change
Content
Session
does not directly implement the various services anymore. Now the services are accessible with a getter. It improves the SDK api, and makes it homogeneous.A few extensions has been added to still be able to do
session.getRoom(roomId)
for instance.Also the
search
method from theRoom
interface has been removed. It was a shortcut.Motivation and context
Have a nicer scoped completion when using the SDK, and make the SDK api more user friendly:
Screenshots / GIFs
Tests
Tested devices