Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notification of invitation does not display the room name #582

Closed
bmarty opened this issue Sep 24, 2019 · 3 comments · Fixed by #4230
Closed

Notification of invitation does not display the room name #582

bmarty opened this issue Sep 24, 2019 · 3 comments · Fixed by #4230
Assignees
@ouchadam
Labels
A-Invite A-Notifications
Milestone
Sprint - Element ...

Comments

@bmarty
Copy link
Member

bmarty commented Sep 24, 2019

Here is the current rendering:

image

The second "RiotX dbg" should be the room name, if available

The NotificationDrawerManager has only the invitation event and not the whole RoomInviteState
@bmarty bmarty added this to the Stabilization2 milestone Sep 24, 2019
@bmarty bmarty mentioned this issue Sep 24, 2019
Merged
6 tasks
@bmarty bmarty mentioned this issue Mar 31, 2021
Closed
@bmarty
Copy link
Member Author

bmarty commented Sep 28, 2021

It should be possible to do better, maybe using room peeking?

@ouchadam ouchadam self-assigned this Oct 12, 2021
@ouchadam ouchadam mentioned this issue Oct 12, 2021
Merged
@ouchadam
Copy link
Contributor

the change #4230 is included in feature/adm/notification-redesign, might be better to close this once the main feature branch is merged

@ouchadam ouchadam linked a pull request Oct 13, 2021 that will close this issue
Including room name in the invitation notification #4230
Merged
@ouchadam ouchadam mentioned this issue Oct 20, 2021
Merged
@ouchadam
Copy link
Contributor

will be available in 1.3.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ouchadam ouchadam

Labels
A-Invite A-Notifications
Projects
None yet
Milestone
Sprint - Element 1.3.2
Development

Successfully merging a pull request may close this issue.

Including room name in the invitation notification element-hq/element-android
2 participants
@ouchadam @bmarty