Promote live location labs flag [PSF-959] #6350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onurays
requested review from
a team,
ouchadam and
ganfra
and removed request for
a team
ouchadam
reviewed
Jun 24, 2022
|
|
||
| <!-- Live Location Sharing Labs Flag Promotional BottomSheet --> | ||
| <string name="live_location_labs_promotion_title">Live location sharing</string> | ||
| <string name="live_location_labs_promotion_description">Please note: this is a labs feature using a temporary implementation. This means you will not be able to delete your location history, and advanced users will be able to see your location history even after you stop sharing your live location with this room.</string> |
There was a problem hiding this comment.
is this the final copy? it's a little bit techy~
There was a problem hiding this comment.
Yes it is. I think it is not so hard to understand for users.
ouchadam
reviewed
Jun 24, 2022
| private val liveLocationLabsFlagPromotionListener = object : VectorBaseBottomSheetDialogFragment.ResultListener { | ||
| override fun onBottomSheetResult(resultCode: Int, data: Any?) { | ||
| // Check if the user wants to enable the labs flag | ||
| if (resultCode == VectorBaseBottomSheetDialogFragment.ResultListener.RESULT_OK && (data as? Boolean) == true) { |
There was a problem hiding this comment.
this comment above could be replaced by extracting this condition to its own function
private fun hasUserOptedInToLiveLocationLabs(code, data) {
return resultCode == VectorBaseBottomSheetDialogFragment.ResultListener.RESULT_OK && (data as? Boolean) == true
}
ouchadam
approved these changes
Jun 24, 2022
ganfra
reviewed
Jun 27, 2022
| companion object { | ||
| fun newInstance(resultListener: ResultListener): LiveLocationLabsFlagPromotionBottomSheet { | ||
| return LiveLocationLabsFlagPromotionBottomSheet().also { | ||
| it.resultListener = resultListener |
There was a problem hiding this comment.
Not a big big deal, but we will loose the listener if the Fragment is recreated by system
| @@ -1047,6 +1047,12 @@ class VectorPreferences @Inject constructor( | |||
| return defaultPrefs.getBoolean(SETTINGS_LABS_ENABLE_LIVE_LOCATION, false) | |||
| } | |||
|
|
|||
| fun setLiveLocationLabsEnabled() { | |||
ganfra
requested changes
Jun 28, 2022
ganfra
reviewed
Jun 28, 2022
| } | ||
| } | ||
|
|
||
| private val fragmentLifecycleCallbacks = object : FragmentManager.FragmentLifecycleCallbacks() { |
There was a problem hiding this comment.
A bit weird to use this for Listener, please use fragment result API instead https://developer.android.com/guide/fragments/communicate#fragment-result
ganfra
approved these changes
Jun 28, 2022
|
Lets merge this if everything is green! |
|
SonarCloud Quality Gate failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Content
We want to show users the Live Location Sharing option with an informative dialog.
Motivation and context
Screenshots / GIFs
Tests
Tested devices
Checklist