Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggest @room when @channel, @everyone, or @here is typed in composer #6529

Closed
bmarty opened this issue Jul 13, 2022 · 1 comment · Fixed by #7000
Closed

Suggest @room when @channel, @everyone, or @here is typed in composer #6529

bmarty opened this issue Jul 13, 2022 · 1 comment · Fixed by #7000
Labels
A-Completion A-Composer help wanted Extra attention is needed T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements Z-parity-with-web

Comments

@bmarty
Copy link
Member

bmarty commented Jul 13, 2022

Currently only @room get the completion.

Location of the change: https://github.com/vector-im/element-android/blob/main/vector/src/main/java/im/vector/app/features/autocomplete/member/AutocompleteMemberPresenter.kt#L148

To be iso EleWeb.

See:
@bmarty bmarty added help wanted Extra attention is needed Z-parity-with-web A-Completion A-Composer T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements labels Jul 13, 2022
@pt2121
Copy link
Contributor

pt2121 commented Sep 3, 2022

Can I take this?

pt2121 added a commit to pt2121/element-android that referenced this issue Sep 4, 2022
@pt2121
Suggest @room when @channel, @everyone, or @here is typed in composer (…
6917e97 
…element-hq#6529)

Signed-off-by: Prat T <pt2121@users.noreply.github.com>
@pt2121 pt2121 mentioned this issue Sep 4, 2022
Merged
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Completion A-Composer help wanted Extra attention is needed T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements Z-parity-with-web
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Suggest @room when @channel, @everyone, or @here is typed in composer pt2121/element-android
2 participants
@pt2121 @bmarty