Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Space Switching Refactoring and Unit Tests #6598

Merged
merged 15 commits into from
Jul 29, 2022
Merged

Space Switching Refactoring and Unit Tests #6598

merged 15 commits into from
Jul 29, 2022

Conversation

ericdecanini
Copy link
Contributor

@ericdecanini ericdecanini commented Jul 19, 2022 •
edited
Loading

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Refactors SpaceStateHandler (previously AppStateHandler) and adds full unit test coverage for it.

No app functionality should change.

Motivation and context

Closes #6483

Screenshots / GIFs

N/A

Tests

  • Smoke test app works as normal

Tested devices

  • Physical
  • Emulator
  • OS version(s): Android 12

Checklist

@ericdecanini ericdecanini mentioned this pull request Jul 19, 2022
Closed
15 tasks
@ericdecanini ericdecanini changed the title Space Switching Unit Tests Space Switching Refactoring and Unit Tests Jul 21, 2022
@ericdecanini
Adds RoomSummaryFixture
1d77f99
@ericdecanini
Moves UiStateRepository stubbing to fake class
d8fdaf0
@ericdecanini
Merge remote-tracking branch 'origin/develop' into task/eric/space-sw…
a909779 
…itching-unit-tests

# Conflicts:
#	vector/src/main/java/im/vector/app/features/home/room/list/RoomListViewModel.kt
@ericdecanini ericdecanini marked this pull request as ready for review July 21, 2022 08:49
@ericdecanini ericdecanini requested review from fedrunov and a team July 21, 2022 08:49
@bmarty bmarty removed the request for review from a team July 25, 2022 10:47
fedrunov
fedrunov approved these changes Jul 27, 2022
View reviewed changes
Copy link
Contributor

@fedrunov fedrunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vector/src/main/java/im/vector/app/SpaceStateHandler.kt
import org.matrix.android.sdk.api.session.Session
import org.matrix.android.sdk.api.session.room.model.RoomSummary

interface SpaceStateHandler : DefaultLifecycleObserver {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please write some doc to explain purpose of this class?

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

60.8% 60.8% Coverage
0.0% 0.0% Duplication

@ericdecanini ericdecanini merged commit ddaf112 into develop Jul 29, 2022
@ericdecanini ericdecanini deleted the task/eric/space-switching-unit-tests branch July 29, 2022 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fedrunov fedrunov fedrunov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Write Unit Tests for Space Switching
2 participants
@ericdecanini @fedrunov