Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New App Layout FABs #6693

Merged
merged 8 commits into from
Aug 10, 2022
Merged

New App Layout FABs #6693

merged 8 commits into from
Aug 10, 2022

Conversation

ericdecanini
Copy link
Contributor

@ericdecanini ericdecanini commented Jul 29, 2022

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Adds the new FABs to be used in the New App Layout. These will be hidden behind the New App Layout feature flag

Motivation and context

Closes #6582

Screenshots / GIFs

Feature Flag Off Feature Flag On
Light
Dark
Black

Tests

  • Enable the New App Layout feature flag
  • Sign in and see the FABs

Currently the FABs do not do anything on click. This will be handled in a separate PR

Tested devices

  • Physical
  • Emulator
  • OS version(s): Android 11

Checklist

@ericdecanini ericdecanini requested a review from fedrunov July 29, 2022 13:58
@ericdecanini ericdecanini marked this pull request as ready for review July 29, 2022 14:05
@ericdecanini ericdecanini requested a review from amshakal July 29, 2022 14:06
Copy link

@amshakal amshakal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

We might change the icon for space switching based on feedback we recieve this week but the rest is perfect!

}

views.newLayoutOpenSpacesButton.setOnClickListener {
// Click action for open spaces modal goes here
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

worth to put here a todo with issue number

showFABs()

views.newLayoutCreateChatButton.setOnClickListener {
// Click action for create chat modal goes here
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing implementation

@ericdecanini ericdecanini requested a review from fedrunov August 2, 2022 15:45
@ElementBot
Copy link

ElementBot commented Aug 5, 2022

Warnings
⚠️

vector/src/main/res/drawable/ic_open_spaces.xml#L7 - This tag is not supported in images generated from this vector icon for API < 24; check generated icon to make sure it looks acceptable

⚠️

vector/src/main/res/drawable/ic_open_spaces.xml#L7 - This tag is not supported in images generated from this vector icon for API < 24; check generated icon to make sure it looks acceptable

⚠️

vector/src/main/res/layout/fragment_room_list.xml#L8 - Possible overdraw: Root element paints background ?android:colorBackground with a theme that also paints a background (inferred theme is @style/Theme.Vector.Light)

⚠️

vector/src/main/res/layout/fragment_room_list.xml#L8 - Possible overdraw: Root element paints background ?android:colorBackground with a theme that also paints a background (inferred theme is @style/Theme.Vector.Light)

⚠️

vector/src/main/res/layout/fragment_room_list.xml#L34 - Attribute accessibilityTraversalBefore is only used in API level 22 and higher (current min is 21)

⚠️

vector/src/main/res/layout/fragment_room_list.xml#L34 - Attribute accessibilityTraversalBefore is only used in API level 22 and higher (current min is 21)

⚠️

vector/src/main/res/layout/fragment_room_list.xml#L50 - Attribute accessibilityTraversalBefore is only used in API level 22 and higher (current min is 21)

⚠️

vector/src/main/res/layout/fragment_room_list.xml#L50 - Attribute accessibilityTraversalBefore is only used in API level 22 and higher (current min is 21)

Generated by 🚫 dangerJS against af04221

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 9, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@ericdecanini ericdecanini merged commit ce4ab78 into develop Aug 10, 2022
@ericdecanini ericdecanini deleted the feature/eric/new_fab branch August 10, 2022 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Space Switching: FABs (Create Room and View Spaces)
4 participants