Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not show push notification for thread, when thread timeline is observed by user #7634

Closed
fedrunov opened this issue Nov 24, 2022 · 0 comments · Fixed by #7641
Closed

Do not show push notification for thread, when thread timeline is observed by user #7634

fedrunov opened this issue Nov 24, 2022 · 0 comments · Fixed by #7641
Assignees
@fedrunov
Labels
A-Threads An issue for the Threads project O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience T-Task Refactoring, enabling or disabling functionality, other engineering tasks Team: Delight

Comments

@fedrunov
Copy link
Contributor

Currently we don't show push notifications for room which is observed by user, but we don't take in account threads. We should instead only hide notifications for a timeline which is observed (main or thread)
@fedrunov fedrunov self-assigned this Nov 25, 2022
@fedrunov fedrunov added O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience T-Task Refactoring, enabling or disabling functionality, other engineering tasks Team: Delight A-Threads An issue for the Threads project labels Nov 25, 2022
@fedrunov fedrunov mentioned this issue Nov 25, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fedrunov fedrunov

Labels
A-Threads An issue for the Threads project O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience T-Task Refactoring, enabling or disabling functionality, other engineering tasks Team: Delight
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ignore push for a thread if it's currently visible to user element-hq/element-android
1 participant
@fedrunov