Fix crash when invalid url is entered #7672 #7684

bmarty · 2022-12-01T14:37:32Z

Type of change

Feature
Bugfix
Technical
Other :

Content

Invoke checkQrCodeLoginCapability() only after the homeserver url has been safely validated.

Motivation and context

Fixes #7672

Screenshots / GIFs

Tests

See Change of server with invalid URL caused crash #7672

Tested devices

Physical
Emulator
OS version(s):

Checklist

Changes has been tested on an Android device or Android emulator with API 21
UI change has been tested on both light and dark themes
Accessibility has been taken into account. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#accessibility
Pull request is based on the develop branch
Pull request includes a new file under ./changelog.d. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#changelog
Pull request includes screenshots or videos if containing UI changes
Pull request includes a sign off
You've made a self review of your PR
If you have modified the screen flow, or added new screens to the application, you have updated the test UiAllScreensSanityTest.allScreensTest()

ElementBot · 2022-12-01T14:40:45Z

	Fails
🚫	`node` failed.

Log

Error:  Error: Could not find the Dangerfile at tools/danger/dangerfile-lint.js - does a file exist at dangerfile-lint.js in tools/danger?.
    at /usr/src/danger/distribution/platforms/GitHub.js:166:27
    at step (/usr/src/danger/distribution/platforms/GitHub.js:44:23)
    at Object.next (/usr/src/danger/distribution/platforms/GitHub.js:25:53)
    at fulfilled (/usr/src/danger/distribution/platforms/GitHub.js:16:58)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)
danger-results://tmp/danger-results-69a989a1.json

Generated by 🚫 dangerJS against d96ff6e