Rich text editor: improve performance when changing composer mode #7691
Conversation
LogError: Error: Could not find the Dangerfile at tools/danger/dangerfile-lint.js - does a file exist at dangerfile-lint.js in tools/danger?.
at /usr/src/danger/distribution/platforms/GitHub.js:166:27
at step (/usr/src/danger/distribution/platforms/GitHub.js:44:23)
at Object.next (/usr/src/danger/distribution/platforms/GitHub.js:25:53)
at fulfilled (/usr/src/danger/distribution/platforms/GitHub.js:16:58)
at processTicksAndRejections (internal/process/task_queues.js:95:5)
danger-results://tmp/danger-results-5ac9f88b.json |
| @@ -363,6 +370,9 @@ class RichTextComposerLayout @JvmOverloads constructor( | |||
| } | |||
|
|
|||
| override fun renderComposerMode(mode: MessageComposerMode) { | |||
| if (this.composerMode == mode) return | |||
There was a problem hiding this comment.
It's worth noting that MessageComposerMode.Quote and MessageComposerMode.Reply are not data class, so maybe == will not work as expected here.
When replying to someone, then (without sending the message), reply to someone else, does the original sender name updates properly?
There was a problem hiding this comment.
It's worth noting that MessageComposerMode.Quote and MessageComposerMode.Reply are not data class, so maybe == will not work as expected here.
I just changed it so they're data classes too (I don't really remember why they weren't in the first place).
When replying to someone, then (without sending the message), reply to someone else, does the original sender name updates properly?
Yes, both before and after making Reply a data class.
jmartinesp
force-pushed
the
fix/improve-performance-when-changing-composer-mode
branch
from
09f71af to
f4c071b
Compare
|
SonarCloud Quality Gate failed. |
jmartinesp
deleted the
fix/improve-performance-when-changing-composer-mode
branch
Type of change
Content
Store the current
MessageComposerModeso we can diff and avoid unnecessary updates.Also, only change some layout params for the editor if we don't want to animate the full screen change (keeps compatibility with both Element Android and Element X).
Motivation and context
Element X stopped properly responding to input as the
renderComposerModemethod was being triggered for each change (on Element Android this is not so noticeable). It also had some issues with resizing the editor properly.As both apps share most of this code, it's better to also handle it properly here.
Screenshots / GIFs
Tests
It's quite difficult to test, as it wasn't a noticeable issue in Element Android.
There should be no issues when writing or 'flashes'.
Tested devices
Checklist