Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inline code formatted messages display with extra line breaks #7975

Closed
jonnyandrew opened this issue Jan 19, 2023 · 2 comments · Fixed by #8011
Closed

Inline code formatted messages display with extra line breaks #7975

jonnyandrew opened this issue Jan 19, 2023 · 2 comments · Fixed by #8011
Labels
A-Timeline O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems

Comments

@jonnyandrew
Copy link
Contributor

Steps to reproduce

  1. Send the following formatted message:
```
Code block
```
Followed by `inline code`

Outcome

What did you expect?

The message is displayed correctly in the timeline e.g.

Code block

Followed by inline code

What happened instead?

The message is not displayed correctly in the timeline. Note the extra new line:

Code block

Followed by
inline code

Here's a comparison of how the same message looks in Element Web vs Element Android:

Element Web Element Android

Your phone model

Google Pixel 6a

Operating system version

Android 13

Application version and app store

1.5.20

Homeserver

matrix.org

Will you send logs?

No

Are you willing to provide a PR?

Yes
@jonnyandrew jonnyandrew added T-Defect Something isn't working: bugs, crashes, hangs and other reported problems A-Timeline S-Minor Impairs non-critical functionality or suitable workarounds exist O-Occasional Affects or can be seen by some users regularly or most users rarely labels Jan 19, 2023
@jonnyandrew
Copy link
Contributor Author

I believe this is a bug with the underlying HTML parser from Markwon (see noties/Markwon#423)

@jmartinesp
Copy link
Member

On my device, it rendered fine for a second or so, then was re-rendered with the extra new lines. Maybe we're post-processing the contents at some point?

@jonnyandrew jonnyandrew mentioned this issue Jan 26, 2023
Merged
15 tasks
jonnyandrew added a commit that referenced this issue Jan 30, 2023
@jonnyandrew
[Rich text editor] Add inline code to rich text editor (#8011)
00f9c36 
Also:
- Fixes #7975
- See noties/Markwon#423
@jonnyandrew jonnyandrew mentioned this issue Feb 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Timeline O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Rich text editor] Add inline code to rich text editor element-hq/element-android
2 participants
@jmartinesp @jonnyandrew