Apple app site associations fixes #1693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://developer.apple.com/videos/play/wwdc2019/717/ ``` You'll notice that I specify a question mark and an asterisk as the pattern from the query items value. A pattern consisting of a single asterisk matches any string, including the empty string. And a missing query item has a value equivalent to the empty string. So to match against the string that's at least one character long, I specify a question mark and then any additional characters are matched by the asterisk. ```
https://developer.apple.com/videos/play/wwdc2019/717/ ``` This file should be located at HTTPS://your domain name/.well-known/apple-app-site-association Other paths are deprecated. ```
stefanceriu
force-pushed
the
stefan/appleAppSiteAssociations
branch
from
2733be7
to
62a80ee
Compare
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## livekit #1693 +/- ##
========================================
Coverage 29.86% 29.86%
========================================
Files 47 47
Lines 1875 1875
Branches 328 328
========================================
Hits 560 560
Misses 1274 1274
Partials 41 41
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
dbkr
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Universal links stopped working following the introduction for the new format and the
no_universal_linkquery exclusion.It seems that specifying
*for it means it would match even when it's completely missing. See this wwdc video around the 8 minute mark. The fix is to use?*instead.It also seems that correct place for this file is .well-known and all other previously supported locations are now deprecated
Relates to element-hq/element-x-ios#1824