Disables HardwareMediaKeyHandling #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tomvaneyck, thanks for working on this! Could you please include a sign-off as described here? |
|
Also, could this or something similar be done in the react-sdk? I think there is a similar problem in browsers, right? Ideally, this would be done for the specific video/audio element, but I don't know if that is even possible |
Signed-off-by: Tom Van Eyck <tom.vaneyck@telenet.be>
|
The spec responsible for this functionality is called the Media Session API. The spec doesn't say anything about disabling this per element, as the browser is responsible for this subsystem. This is confirmed in this issue. If this should be set on a per element basis, the spec would need to change. |
Co-authored-by: Šimon Brandner <simon.bra.ag@gmail.com> Signed-off-by: Tom Van Eyck <tom.vaneyck@telenet.be>
jryans
approved these changes
Apr 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix element-hq/element-web#15704 as suggested by tretum.
PS: This is a quick fix. IMO it should be possible to add (via a config file or in-app settings) random flags like this one that electron supports. But that is a different story.