Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put Preferences menu item in correct location on macOS #200

Merged
merged 2 commits into from
Jun 4, 2021

Conversation

aaronraimist
Copy link
Contributor

Fixes element-hq/element-web#17549

This has only been tested on macOS.

Signed-off-by: Aaron Raimist <aaron@raim.ist>
…bout menu item

Signed-off-by: Aaron Raimist <aaron@raim.ist>
@aaronraimist
Copy link
Contributor Author

Also added an ellipsis after the word "Preferences" like the HIG says to do https://developer.apple.com/design/human-interface-guidelines/macos/menus/menu-anatomy/

@turt2live turt2live requested a review from a team June 4, 2021 05:17
Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks

@t3chguy t3chguy merged commit 330e230 into element-hq:develop Jun 4, 2021
@aaronraimist aaronraimist deleted the macos-preferences branch June 4, 2021 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[macOS] Preferences menu item should be under the Element menu, not the View menu
2 participants