Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support universal builds #226

Merged
merged 3 commits into from
Jul 7, 2021
Merged

Support universal builds #226

merged 3 commits into from
Jul 7, 2021

Conversation

dbkr
Copy link
Member

@dbkr dbkr commented Jul 6, 2021

Hopefully adequately documented in the README

Hopefully adequately documented in the README
@dbkr dbkr requested a review from a team July 6, 2021 22:54
Copy link
Contributor

@jryans jryans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exciting, thanks for working on this! 😄

package.json Outdated
"build32": "yarn run build:ts && yarn run build:res && electron-builder --ia32",
"build64": "yarn run build:ts && yarn run build:res && electron-builder --x64",
"builduniversal": "yarn run build:ts && yarn run build:res && electron-builder --universal",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I sort of wonder if this one should be build:universal, and then build:32 as well... just a bit strange that some things use colon separate and others don't.

dbkr and others added 2 commits July 7, 2021 11:01
Co-authored-by: J. Ryan Stinnett <jryans@gmail.com>
@dbkr dbkr merged commit a8f44fd into develop Jul 7, 2021
@t3chguy t3chguy deleted the dbkr/universally_speaking branch May 3, 2022 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants