Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If QR scan is the only verification option, we should jump straight to scanning rather than prompt a menu with one item #3115

Closed
ara4n opened this issue Apr 16, 2020 · 3 comments · Fixed by #7381

Comments

@ara4n
Copy link
Member

ara4n commented Apr 16, 2020

Sorry if I missed the answer on Matrix (I can't find where i asked it; sorry), but:

image

^ this screen makes no sense; surely we should jump straight into scanning.

@giomfo
Copy link
Member

giomfo commented Feb 10, 2023

A case where the code is visible only on one device has been reproduced with Element-iOS
1- Consider an iOS session where the cross-signing is enabled
2- Trigger from this session the verification of a new unverified session
3- Accept the incoming verification request

a QR code is displayed on the new session screen, but no QR code is displayed on the first session
image

@pmaier1 @americanrefugee I would like to fix this UI issue in Element-iOS

What should we do ?

  • jump straight to scanning rather than prompt a menu with one item
    or
  • update this screen to keep the possibility to jump back on an emoji verification (= "can't scan?" option)
  • ...

@americanrefugee
Copy link

What do you think about this design @giomfo ?

Scan QR code

Link to Figma file

@giomfo
Copy link
Member

giomfo commented Feb 14, 2023

@nimau can you please check the suggested design?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants