Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image shared from external app sent as file #3636

Closed
drasbeck opened this issue Sep 8, 2020 · 3 comments · Fixed by #5507
Closed

Image shared from external app sent as file #3636

drasbeck opened this issue Sep 8, 2020 · 3 comments · Fixed by #5507
Assignees
Labels
A-Composer Z-D1 Issues that can impact the Day-2 retention Z-Impact-2 Z-Papercuts Visible. Impactful. Predictable to action. Z-Visibility-2

Comments

@drasbeck
Copy link

drasbeck commented Sep 8, 2020

Actual behavior: Sharing an image from an external app, e.g., Nextcloud, Apollo, to an e2e encrypted room sends the image as a file, thus no image/thumbnail is shown. And it must be decrypted + downloaded to open.

Intended behavior: Sharing an image from an external app, should send the image as image, such that it is shown in the room.

I have not tested this behavior in unencrypted rooms.

@bw3
Copy link

bw3 commented Feb 19, 2021

I suspect this is caused by the order of the type checks in this file:
https://github.com/vector-im/element-ios/blob/develop/RiotShareExtension/Managers/ShareExtensionManager.m
I think the if ([itemProvider hasItemConformingToTypeIdentifier:UTTypeFileUrl]) section is matching on all files (including image files) and should be moved to the end.

@einmueller
Copy link

The problem still exists and is very annoying, especially when trying to get people away from other Messengers to Matrix.

Any Chance to get this solved?

@ShadowJonathan
Copy link
Contributor

CC @pixlwave eligible for papercut triage?

@pixlwave pixlwave added Z-Impact-2 Z-Papercuts Visible. Impactful. Predictable to action. Z-Visibility-2 A-Composer labels Aug 16, 2021
@daniellekirkwood daniellekirkwood added the Z-D1 Issues that can impact the Day-2 retention label Oct 18, 2021
@aringenbach aringenbach self-assigned this Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Composer Z-D1 Issues that can impact the Day-2 retention Z-Impact-2 Z-Papercuts Visible. Impactful. Predictable to action. Z-Visibility-2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants