Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSG_FROM_USER_IN_ROOM_TITLE in notification title when system language set to Japanese #3908

Closed
neutralinsomniac opened this issue Jan 7, 2021 · 6 comments
Closed

MSG_FROM_USER_IN_ROOM_TITLE in notification title when system language set to Japanese #3908

neutralinsomniac opened this issue Jan 7, 2021 · 6 comments
Labels
I18n Internationalisation and localisation issues. O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Something isn't working: bugs, crashes, hangs and other reported problems

Comments

@neutralinsomniac
Copy link

Describe the bug
See issue title

To Reproduce

  1. Set iPhone language to Japanese
  2. Receive message notification
  3. Observe incorrect notification title (MSG_FROM_USER_IN_ROOM_TITLE)

Expected behavior
Actual room name to appear in notification title.

  • OS: iOS
  • Version 14.3

Smartphone (please complete the following information):

  • Device: iPhone 12 Mini
  • OS: iOS14.3
@ghost
Copy link

ghost commented Oct 3, 2021

Commenting to confirm this still occurs on version 1.5.4. I used an iPhone 12 mini running iOS 14.8. This seems like a very strange bug since the placeholder string is already localized.

@pixlwave pixlwave added I18n Internationalisation and localisation issues. O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Something isn't working: bugs, crashes, hangs and other reported problems labels Oct 21, 2021
@pixlwave
Copy link
Member

pixlwave commented Oct 21, 2021 •
edited
Loading

Updating this issue to mention a report that the same behaviour is seen when Element fails to get the message content - the notification title reads "NOTIFICATION" instead of the Japanese translation.

Sounds like it's possible that none of the Japanese strings are being translated in the NSE.

@pixlwave pixlwave mentioned this issue Nov 1, 2021
Merged
@pixlwave
Copy link
Member

Hi @neutralinsomniac @kakuhen, would either of you be able to confirm if you're still seeing this behaviour now that #5075 is merged? Thanks.

@neutralinsomniac
Copy link
Author

neutralinsomniac commented Jan 13, 2022 via email

@pixlwave
Copy link
Member

Thanks that's great news 🎉 I'll close this issue following #5075.

@ghost
Copy link

ghost commented Jan 26, 2022 •
edited by ghost
Loading

Sorry for the late response, I can confirm that this particular issue appears to be fixed on the latest App Store version of Element (1.6.12). Thank you for fixing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
I18n Internationalisation and localisation issues. O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@neutralinsomniac @pixlwave