-
Notifications
You must be signed in to change notification settings - Fork 498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove resolution selection when sending image #4479
Comments
Wait, is this Element iOS specific? for the longest time i just thought this was an iOS thing other apps opted out of. If so, yes, but maybe pop it up when images start getting larger than 5 MB. |
I'd like to keep this - I use it constantly to decide how much bandwidth to burn on a given image. |
Even though it would be kept, it would make a platform discrepancy between mobile clients (like manu said), maybe make it opt-in configurable? |
Might it make sense to move the selection inline with the image preview? Similar to how Android has an option there for whether or not to compress a video (element-hq/element-android#3264). |
Compressing things to some degree sounds really reasonable to me. The only issue might be that, as we support iPad, we might need to be aware of how things look on a 12.9" phone. From the link, I can't work out what defines when something is too big to be uploaded?
It sounds like in this insight, the user is deciding themselves, so it feels like the system decided when something is too big is maybe not appropriate? When I try to send an email with an attachment on iOS sometimes I get something like the below image, but not sure who is deciding what's too large.
To me, that sounds reasonable. There could be a data-friendly mode or something that could include a few things:
|
After a brief design exploration of the issue we came to some solutions:
This follows @ShadowJonathan's suggestion that people can opt-into this if they want the resolution selection to persist.
Would give people (harder) access to the option if they needed it, but make the flow easier for most users who don't want to edit size. We did consider some other ideas, but they expanding the work more than we probably require at this stage. |
Ok yep interesting ideas. Both sound potentially good options to me 👍 |
Do we still need this v when sending an image?
Element-Android doest not have it.
Plus, the implementation is currently buggy on iOS.
The text was updated successfully, but these errors were encountered: