-
Notifications
You must be signed in to change notification settings - Fork 498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace notifications toggle with a link to the settings app. #4575
Conversation
…vour of UNUserNotificationCenter.
Enabling notifications with this PR implemented: New_480.movThe same, but using the old toggle: Old_480.mov |
After discussing, we agreed that whilst this fixes a lot of issues with notifications, it makes the primary flow a bit harder - as to turn off notifications now would take a bit longer and more interactions. When someone is trying to turn on/off notifications, it's normally a time-sensitive task, and taking longer than expected there would be a new papercut. We agreed to keep the exisitng toggle for the quick turn on off and introduce a way to device notifications. Reference (as it is now, just for reference) Option 1 Option 2 Option 3 |
1f20611
to
88660d5
Compare
Updated to include the original toggle as well as the new link to the system settings app. The behaviour of the old toggle has been updated to include support for background notifications. NotificationSettings2-480p.mov |
@pixlwave could we amend to alert to be more actionable, with a cancel and a settings action that goes to the relevant device notifications? |
Yep, much better! NotificationsAlert-480p.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Summary of final changes:
|
…tor-im/element-ios into doug/2368_allow_silent_notifications
Fixes #2368. Depends on matrix-org/matrix-ios-kit#865.
Outdated: