Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The Room Directory doesn't allow you to switch network if there are no results. #4700

Closed
pixlwave opened this issue Aug 12, 2021 · 4 comments · Fixed by #6498 or #6500
Closed

The Room Directory doesn't allow you to switch network if there are no results. #4700

pixlwave opened this issue Aug 12, 2021 · 4 comments · Fixed by #6498 or #6500
Labels
T-Defect Something isn't working: bugs, crashes, hangs and other reported problems Z-D1 Issues that can impact the Day-2 retention Z-FAB Z-Impact-1 Z-Ready This issue is ready for development Z-Visibility-1 Z-WTF WTF issues: High impact, Low Effort

Comments

@pixlwave
Copy link
Member

When using an account on matrix.org, opening the room directory provides a list of rooms and at the top a header where you can switch networks. However on other homeservers, if there are no rooms to show, the screen is completely empty.

Steps to reproduce:

Steps to reproduce the behavior:

  1. Log in with an account for a self-hosted homeserver
  2. Open the rooms tab and tap the #+ button
  3. The screen you are presented with looks like this:

IMG_399D5A1794EF-1

Contextual information

  • OS: iOS 14
  • App Version: 1.4.9
@pixlwave pixlwave added T-Defect Something isn't working: bugs, crashes, hangs and other reported problems Z-Impact-1 Z-Papercuts Visible. Impactful. Predictable to action. Z-Visibility-1 labels Aug 12, 2021
@daniellekirkwood daniellekirkwood added the Z-D1 Issues that can impact the Day-2 retention label Oct 18, 2021
@daniellekirkwood daniellekirkwood added Z-FAB X-Needs-Design May require input from the design team X-Needs-Product Requires input from the product team labels Nov 15, 2021
@daniellekirkwood daniellekirkwood added the Z-WTF WTF issues: High impact, Low Effort label Jan 7, 2022
@daniellekirkwood
Copy link
Contributor

We need to add the Matrix Network "Switch" bar to this screen when user is on their own homeserver that does not have public rooms.

@daniellekirkwood daniellekirkwood removed the Z-Papercuts Visible. Impactful. Predictable to action. label Jan 24, 2022
@daniellekirkwood
Copy link
Contributor

daniellekirkwood commented Feb 2, 2022 •
edited
Loading

Removing the Needs-Product label as Product agrees that this is necessary...!

I'm also going to remove the Needs-Design label as we want to implement the already available Switch button...

@pixlwave Tagging you for visibility and agreement... We want to add this right?

image

@daniellekirkwood daniellekirkwood removed the X-Needs-Product Requires input from the product team label Feb 2, 2022
@daniellekirkwood daniellekirkwood added Z-Ready This issue is ready for development and removed X-Needs-Design May require input from the design team labels Feb 2, 2022
@daniellekirkwood daniellekirkwood removed their assignment Feb 2, 2022
@pixlwave
Copy link
Member Author

pixlwave commented Feb 3, 2022

Yep, that's the one 👍

@daniellekirkwood daniellekirkwood self-assigned this Feb 16, 2022
@daniellekirkwood daniellekirkwood removed their assignment May 30, 2022
@lilchancep
Copy link

Just confirming this issue still exists.

OS: iOS 15.6
App Version: 1.8.23

@vollkorntomate vollkorntomate mentioned this issue Jul 31, 2022
Merged
8 tasks
pixlwave added a commit that referenced this issue Aug 1, 2022
@pixlwave
Merge pull request #6498 from vollkorntomate/develop
c62372a 
Show switch button if there are no public rooms on homeserver (to fix #4700)
@pixlwave pixlwave linked a pull request Aug 1, 2022 that will close this issue
Fix missing errors after #6498. #6500
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T-Defect Something isn't working: bugs, crashes, hangs and other reported problems Z-D1 Issues that can impact the Day-2 retention Z-FAB Z-Impact-1 Z-Ready This issue is ready for development Z-Visibility-1 Z-WTF WTF issues: High impact, Low Effort
Projects
None yet
Milestone
No milestone
4 participants
@pixlwave @lilchancep @amshakal @daniellekirkwood