Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the ObjC Generated Interface Header Name definition #4722

Closed
giomfo opened this issue Aug 17, 2021 · 0 comments
Closed

Improve the ObjC Generated Interface Header Name definition #4722

giomfo opened this issue Aug 17, 2021 · 0 comments
Labels
Sponsored T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements

Comments

@giomfo
Copy link
Member

giomfo commented Aug 17, 2021

Currently, the Element project defined this header with $(SWIFT_MODULE_NAME)-Swift.h

The problem is the resulting header name depends on the selected target.
image

This complicates the import of this header in the source code shared between an extension and the application itself

#ifdef IS_SHARE_EXTENSION
#import "RiotShareExtension-Swift.h"
#else
#import "Riot-Swift.h"
#endif

I suggest here defining a unique header name for all the targets
image

then the import will be everywhere:

#import "GeneratedInterface-Swift.h"
@giomfo giomfo added feature T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements and removed feature labels Aug 17, 2021
@giomfo giomfo closed this as completed Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Sponsored T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
None yet
Development

No branches or pull requests

1 participant