Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some voice messages cannot be played back and have no waveform #4748

Closed
ara4n opened this issue Aug 24, 2021 · 4 comments
Closed

Some voice messages cannot be played back and have no waveform #4748

ara4n opened this issue Aug 24, 2021 · 4 comments
Assignees

Comments

@ara4n
Copy link
Member

ara4n commented Aug 24, 2021

eg https://matrix.to/#/!uZvykYWBAcekzGUFVE%3Amatrix.org/%24VRiws4Kh2Wov989n785VFIa2UsC-AdBTesjSE2RWIDo

@stefanceriu
Copy link
Member

It seems that there is a problem somewhere in the VoiceMessageAttachmentCacheManager that breaks rendering and playback for some of the voice messages. Restarting the app fixes it.
Related logs here - https://github.com/matrix-org/element-ios-rageshakes/issues/11348

@stefanceriu
Copy link
Member

After more investigation this seems to be coming from cached completion handlers not being cleared and waiting for an operation that doesn't exist to finish. Need to find where original operation fails without clearing state.

stefanceriu added a commit that referenced this issue Aug 25, 2021
…sync operations, properly cleaning up callbacks on failure.
stefanceriu added a commit that referenced this issue Aug 25, 2021
…sync operations, properly cleaning up callbacks on failure.
stefanceriu added a commit that referenced this issue Aug 25, 2021
…sync operations, properly cleaning up callbacks on failure.
@twrightsman
Copy link

I can't view the matrix message linked above, but I also have issues where people on Element iOS can't listen to my voice messages sent from Element Flatpak or Element Android. On the iOS end they look like:

voice-message-waveform

I am able to listen to their messages just fine and listen to my own.
Is this the same issue?

@stefanceriu
Copy link
Member

Hi, thank you for reporting this. I can't be sure but it does indeed feel like the same problem. Hopefuly you won't see it anymore starting next release 🤞

@stefanceriu stefanceriu changed the title voice msg waveforms recorded on web have no height on iOS Some voice messages cannot be played back and have no waveform Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants