Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved converted voice messages to their own folder. Cleaning up all temporary files on on reload and logout. #4770

Merged
merged 1 commit into from
Sep 1, 2021
Merged

Moved converted voice messages to their own folder. Cleaning up all temporary files on on reload and logout. #4770

merged 1 commit into from
Sep 1, 2021

Conversation

stefanceriu
Copy link
Member

No description provided.

@stefanceriu stefanceriu changed the title Moved converted voice messages to their own folder. Cleaning up all temporary files on Moved converted voice messages to their own folder. Cleaning up all temporary files on on reload and logout. Aug 30, 2021
@github-actions
Copy link

github-actions bot commented Aug 30, 2021 •
edited
Loading

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/7iEGXA

@langleyd
Copy link
Member

langleyd commented Sep 1, 2021 •
edited
Loading

Any chance you could link the issue?

langleyd
langleyd reviewed Sep 1, 2021
View reviewed changes
Copy link
Member

@langleyd langleyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of nits and 1 question.

Riot/Modules/Room/VoiceMessages/VoiceMessageAttachmentCacheManager.swift Outdated Show resolved Hide resolved
Riot/Modules/Room/VoiceMessages/VoiceMessageAttachmentCacheManager.swift Outdated Show resolved Hide resolved
Riot/Modules/Room/VoiceMessages/VoiceMessageAttachmentCacheManager.swift Show resolved Hide resolved
@stefanceriu stefanceriu merged commit c5e53d1 into develop Sep 1, 2021
@stefanceriu stefanceriu deleted the stefan/temporaryFileCleanup branch September 1, 2021 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@langleyd langleyd langleyd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stefanceriu @langleyd