Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Space view has communities tab at the bottom of the screen #4846

Closed
2 tasks
kittykat opened this issue Sep 16, 2021 · 1 comment
Closed
2 tasks

Space view has communities tab at the bottom of the screen #4846

kittykat opened this issue Sep 16, 2021 · 1 comment
Assignees
@niquewoodhouse @gileluard
Labels
A-Spaces Spaces, groups, communities O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Something isn't working: bugs, crashes, hangs and other reported problems X-Release-Blocker Z-Spaces-Testing

Comments

@kittykat
Copy link
Contributor

kittykat commented Sep 16, 2021 •
edited
Loading

Steps to reproduce

  1. Be in a Space, look at bottom right of screen and see Communities tab/icon

What happened?

Spaces and communities are mutually exclusive so shouldn't be able to have communities for a space - need confirmation on this.

Your phone model

No response

Operating system version

No response

Application version

1.5.4 (Gil's version for testing spaces)

Homeserver

No response

Have you submitted a rageshake?

No

Acceptance criteria

  • [BLOCKER] Show a user a UI which isn't a blank tab (see post below)
  • [not a blocker] Do a conditional check to see if a user is a member of communities and don't show the tab if they are not
@kittykat kittykat added T-Defect Something isn't working: bugs, crashes, hangs and other reported problems A-Spaces Spaces, groups, communities S-Major Severely degrades major functionality or product features, with no satisfactory workaround O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience Z-Spaces-Testing labels Sep 16, 2021
@kittykat
Copy link
Contributor Author

@niquewoodhouse can you provide Gil with a graphic and copy to say "it doens't look like you're a member of any communities, please use Spaces to create communities no Matrix" or something like that

gileluard added a commit that referenced this issue Sep 22, 2021
@gileluard
[spaces] several fixes for pre release
3a2548a 
- [Space view has communities tab at the bottom of the screen](#4846)
@gileluard gileluard mentioned this issue Sep 23, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@niquewoodhouse niquewoodhouse

@gileluard gileluard

Labels
A-Spaces Spaces, groups, communities O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Something isn't working: bugs, crashes, hangs and other reported problems X-Release-Blocker Z-Spaces-Testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kittykat @niquewoodhouse @gileluard