Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundancy in heading in bug report issue form #4984

Merged
merged 3 commits into from
Nov 16, 2021
Merged

Remove redundancy in heading in bug report issue form #4984

merged 3 commits into from
Nov 16, 2021

Conversation

opusforlife2
Copy link
Contributor

@opusforlife2 opusforlife2 commented Oct 11, 2021

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request contains a changelog file in ./changelog.d
  • You've made a self review of your PR

This is a follow-up PR to element-hq/element-android#4076. @kittykat Here you go.

Also made the subheadings one size smaller (4 #'s instead of 3)
Copy link
Contributor Author

@opusforlife2 opusforlife2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's the self review: "Changes seem fine." ... not sure what the point of this is, though?

@opusforlife2
Copy link
Contributor Author

@kittykat Hey did you miss the mention notification?

@opusforlife2
Copy link
Contributor Author

@pixlwave Hi, sorry for the unsolicited ping. Could you or someone else on the team please request a review from @kittykat on this PR? Thanks in advance.

.github/ISSUE_TEMPLATE/bug.yml Outdated Show resolved Hide resolved
@kittykat
Copy link
Contributor

Here's the self review: "Changes seem fine." ... not sure what the point of this is, though?

I think the intention here is to remind people to look over their commits before submitting the PR, at least to check for typos, whitespace and things like that.

@kittykat
Copy link
Contributor

@opusforlife2 If you could add a signoff to this PR as well, then IMO it would be ready to merge

@kittykat kittykat merged commit 9da5ee5 into element-hq:develop Nov 16, 2021
@kittykat
Copy link
Contributor

As per discussion in element-hq/element-android/pull/4257 , merging

@opusforlife2 opusforlife2 deleted the issue_template branch November 17, 2021 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants