Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MatrixSDK: Replace semantic imports @import by #import #5046

Closed
SBiOSoftWhare opened this issue Oct 25, 2021 · 0 comments · Fixed by matrix-org/matrix-ios-sdk#1287
Closed

MatrixSDK: Replace semantic imports @import by #import #5046

SBiOSoftWhare opened this issue Oct 25, 2021 · 0 comments · Fixed by matrix-org/matrix-ios-sdk#1287
Labels
A-SDK T-Task Refactoring, enabling or disabling functionality, other engineering tasks

Comments

@SBiOSoftWhare
Copy link
Contributor

Semantic creates issues for Kotlin Multiplatform Mobile and C++20 compatibility.
As pointed here we can get rid of them as the compiler makes the optimisation:

You don't actually need to use the @import keyword. If you opt-in to using modules, all #import and #include directives are mapped to use @import automatically.
@SBiOSoftWhare SBiOSoftWhare mentioned this issue Oct 25, 2021
Closed
@pixlwave pixlwave added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Oct 27, 2021
Johennes added a commit to Johennes/matrix-ios-sdk that referenced this issue Nov 6, 2021
@Johennes
Use classic instead of semantic imports
b8a61ae 
This replaces all semantic import statements with classic ones.
Semantic imports are currently not supported in Kotlin Multiplatform
Mobile projects which makes the SDK unusable in these cases.

Signed-off-by: Johannes Marbach <n0-0ne+github@mailbox.org>
Fixes: element-hq/element-ios#5046
@Johennes Johennes mentioned this issue Nov 6, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-SDK T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use classic instead of semantic imports Johennes/matrix-ios-sdk
2 participants
@SBiOSoftWhare @pixlwave