Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Favouriting a DM no longer removes it from the People section. #5081

Open
pixlwave opened this issue Nov 2, 2021 · 3 comments · Fixed by #5087
Open

Favouriting a DM no longer removes it from the People section. #5081

pixlwave opened this issue Nov 2, 2021 · 3 comments · Fixed by #5087
Labels
A-Room-List O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Tolerable Low/no impact on users T-Defect Something isn't working: bugs, crashes, hangs and other reported problems

Comments

@pixlwave
Copy link
Member

pixlwave commented Nov 2, 2021

Steps to reproduce

  1. Favourite the most recent DM from the home screen

What happened?

What did you expect?

That the avatar moves from the People section up into the Favourites section (like happens for rooms).

What happened?

The avatar stayed in the People section with another one appearing in the Favourites section.

Your phone model

iPhone 12

Operating system version

iOS 15.1

Application version

Element 1.6.7 develop

Homeserver

No response

Will you send logs?

No
@pixlwave pixlwave added T-Defect Something isn't working: bugs, crashes, hangs and other reported problems A-Room-List S-Tolerable Low/no impact on users O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience labels Nov 2, 2021
@pixlwave pixlwave mentioned this issue Nov 3, 2021
Merged
@pixlwave pixlwave linked a pull request Nov 3, 2021 that will close this issue
Fix DisabledRoomInputToolbarView / Room Previews / Favourites #5087
Merged
@ShadowJonathan
Copy link
Contributor

I would actually prefer if DMs were always accessible from the DM tab, since then it makes DMs easier to manage

@pixlwave
Copy link
Member Author

pixlwave commented Nov 12, 2021 •
edited
Loading

This issue is just about the sections in the Home tab, the People tab is unaffected.

@ShadowJonathan
Copy link
Contributor

ShadowJonathan commented Nov 12, 2021 •
edited
Loading

Ah, no objections then 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Room-List O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Tolerable Low/no impact on users T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix DisabledRoomInputToolbarView / Room Previews / Favourites element-hq/element-ios
2 participants
@pixlwave @ShadowJonathan