Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accepting a Space Invite has shouty button labels #5175

Closed
pixlwave opened this issue Nov 22, 2021 · 2 comments · Fixed by #5478
Closed

Accepting a Space Invite has shouty button labels #5175

pixlwave opened this issue Nov 22, 2021 · 2 comments · Fixed by #5478
Assignees
@gileluard
Labels
A-Spaces Spaces, groups, communities O-Occasional Affects or can be seen by some users regularly or most users rarely S-Tolerable Low/no impact on users T-Defect Something isn't working: bugs, crashes, hangs and other reported problems

Comments

@pixlwave
Copy link
Member

Steps to reproduce

  1. Receive and invite from another user into a space.
  2. Tap the space invite in the sidebar.

Outcome

What did you expect?

The panel to have button labels with standard title case.

What happened instead?

The button labels are all upper caps. Possibly a localisation bug.

Simulator Screen Shot - iPhone 12 mini - 2021-11-22 at 10 23 18

Your phone model

iPhone 12 mini (simulator

Operating system version

iOS 14.5 (simulator)

Application version

1.6.8

Homeserver

No response

Will you send logs?

No
@pixlwave pixlwave added T-Defect Something isn't working: bugs, crashes, hangs and other reported problems A-Spaces Spaces, groups, communities S-Tolerable Low/no impact on users O-Occasional Affects or can be seen by some users regularly or most users rarely labels Nov 22, 2021
@nadonomy
Copy link
Contributor

nadonomy commented Dec 2, 2021

@niquewoodhouse are you ok to sanity check or +1 on this pls?

@niquewoodhouse
Copy link

This is my mistake - the buttons on iOS tend to not be capitalised, please can the buttons be changed to "Accept" and "Decline" @gileluard ?

@niquewoodhouse niquewoodhouse removed their assignment Feb 1, 2022
@gileluard gileluard self-assigned this Feb 1, 2022
gileluard added a commit that referenced this issue Feb 1, 2022
@gileluard
Accepting a Space Invite has shouty button labels #5175
6001f0c 
- fixed
@gileluard gileluard mentioned this issue Feb 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gileluard gileluard

Labels
A-Spaces Spaces, groups, communities O-Occasional Affects or can be seen by some users regularly or most users rarely S-Tolerable Low/no impact on users T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Accepting a Space Invite has shouty button labels element-hq/element-ios
4 participants
@niquewoodhouse @nadonomy @pixlwave @gileluard