Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the New Room Avatar to Camera Icon #5251

Closed
daniellekirkwood opened this issue Dec 6, 2021 · 4 comments · Fixed by #5635
Closed

Change the New Room Avatar to Camera Icon #5251

daniellekirkwood opened this issue Dec 6, 2021 · 4 comments · Fixed by #5635
Assignees
Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements Z-Ready This issue is ready for development Z-WTF WTF issues: High impact, Low Effort

Comments

@daniellekirkwood
Copy link
Contributor

daniellekirkwood commented Dec 6, 2021

Problem

When a user creates a new room, the default "image" is a big green circle that changes to include the room initial once the room name field has lost focus. This green does not necessarily stay (some room icons are different colours).

Solution

Change the green to a full size version of the camera icon. If the user does not add a photo, create the default icon with the room initials once created (matching the Android behaviour)

From To
Screenshot 2021-12-13 12 38 19 Insert Android screenshot
@daniellekirkwood daniellekirkwood added T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements Z-WTF WTF issues: High impact, Low Effort labels Dec 6, 2021
@daniellekirkwood daniellekirkwood self-assigned this Dec 13, 2021
@daniellekirkwood daniellekirkwood added the Z-Ready This issue is ready for development label Jan 26, 2022
@aringenbach aringenbach self-assigned this Feb 4, 2022
@aringenbach
Copy link
Contributor

Hello @daniellekirkwood
Doing side-by-side comparison I noticed that there is also a button to remove room avatar selection on Android that doesn't exist on iOS. Do you want me to implement this as well as part of this change ?

image

@daniellekirkwood daniellekirkwood added Z-WTF WTF issues: High impact, Low Effort and removed Z-WTF WTF issues: High impact, Low Effort labels Feb 7, 2022
@daniellekirkwood
Copy link
Contributor Author

Discussed in Office Hours today, @amshakal will review these questions once @aringenbach adds screenshots :) THanks!

@aringenbach
Copy link
Contributor

Hello @amshakal

Here are some screenshots of current development to replicate Android version.
From my point of view image should be bigger than now (iPhone SE 2nd gen on screenshots), and colors should be better defined for both dark and light themes)
Due note that current icon is a single element (white round background + camera icon), but this could easily evolve to handle specific coloring.

@aringenbach aringenbach added the X-Needs-Design May require input from the design team label Feb 10, 2022
@amshakal
Copy link

Hi there! This is looking good. Thank you so much! I agree with your suggestions. Ill talk about the in detail below:

  1. Just to check, what's the size of the circle? It should be 80px x 80px.
  2. I also created buttons for both dark and light mode.

Screenshot 2022-02-16 at 7 20 36 pm

Screenshot 2022-02-16 at 7 20 41 pm

Screenshot 2022-02-16 at 7 20 47 pm

Screenshot 2022-02-16 at 7 20 51 pm

Link to figma

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements Z-Ready This issue is ready for development Z-WTF WTF issues: High impact, Low Effort
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants