Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invite user UI is always hidden by the keyboard #5341

Closed
ara4n opened this issue Jan 3, 2022 · 5 comments · Fixed by #6348
Closed

Invite user UI is always hidden by the keyboard #5341

ara4n opened this issue Jan 3, 2022 · 5 comments · Fixed by #6348
Assignees
Labels
A-Invite O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems X-Needs-Design May require input from the design team Z-WTF WTF issues: High impact, Low Effort

Comments

@ara4n
Copy link
Member

ara4n commented Jan 3, 2022

If you press the invite user button, you see this, but hidden by the keyboard, so you can never see the button.

How it looks initially After dismissing the keyboard
760ADD00-8917-4165-A4C4-A99AD57CCD52 image

from #6044

Steps to reproduce

  1. Invite users to a room from the FAB
  2. Observe that the keyboard covers the instructions and there is no way to clear it.

Your phone model

12 pro max

Operating system version

15.4

Application version

18.13 tf

@pixlwave pixlwave added A-Invite O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems Z-Papercuts Visible. Impactful. Predictable to action. labels Jan 11, 2022
@pixlwave pixlwave added Z-WTF WTF issues: High impact, Low Effort and removed Z-Papercuts Visible. Impactful. Predictable to action. labels Apr 19, 2022
@pixlwave pixlwave added the X-Needs-Design May require input from the design team label Apr 19, 2022
@pixlwave
Copy link
Member

pixlwave commented Apr 19, 2022

We should probably not be giving the search field focus by default. This would be a quick fix for the issue and would mean you can see more of your contacts by default once you've granted access to EI.

Tagging as needs design for confirmation.

@gileluard gileluard self-assigned this Jun 20, 2022
@gileluard
Copy link
Contributor

@niquewoodhouse

I found a new built in class we could use so the instructions and the Find you contacts button is not covered anymore by the keyboard:

Image

This class is available since iOS 15. We can also hide the keyboard by default and let the user tap the search textfield.

What's your opinion?

@gileluard
Copy link
Contributor

Note that there is not room to move up the instructions panel for small devices:

Image

@niquewoodhouse
Copy link

What's your opinion?

My vote would be we should not focus the field by default but I do like the built in class work too.

@gileluard
Copy link
Contributor

No problem. The field won't be focused by default and I'll keep my changes so the Find you contacts button won't be covered anymore by the keyboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Invite O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems X-Needs-Design May require input from the design team Z-WTF WTF issues: High impact, Low Effort
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants