Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove "X kicked X" terminology when removing people from a room #5346

Closed
gaelledel opened this issue Jan 5, 2022 · 3 comments · Fixed by #5563
Closed

Remove "X kicked X" terminology when removing people from a room #5346

gaelledel opened this issue Jan 5, 2022 · 3 comments · Fixed by #5563
Assignees
@MaximeEvrard42
Labels
A-Timeline T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements Z-Ready This issue is ready for development Z-WTF WTF issues: High impact, Low Effort

Comments

@gaelledel
Copy link

Your use case

What would you like to do?

To remove the wording "X kicked X" when someone is removed from a room and replace with "X removed X"

Why would you like to do it?

Because it is more acceptable terminology

Have you considered any alternatives?

No response

Additional context

No response
@gaelledel gaelledel added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label Jan 5, 2022
@gaelledel
Copy link
Author

Please note that the term kick will obviously have to be replaced with "remove" at several other areas. Please check @t3chguy PR here for more info matrix-org/matrix-react-sdk#7469
We can therefore use "Remove from chat" in both rooms and DMs

@gaelledel gaelledel added X-Needs-Product Requires input from the product team Z-WTF WTF issues: High impact, Low Effort labels Jan 6, 2022
@daniellekirkwood
Copy link
Contributor

element-hq/element-android#4865

@daniellekirkwood daniellekirkwood added the Z-Ready This issue is ready for development label Feb 2, 2022
@daniellekirkwood
Copy link
Contributor

Removing the Needs-Product label as all decisions have been made. More info in the Android issue id needed

@daniellekirkwood daniellekirkwood removed the X-Needs-Product Requires input from the product team label Feb 8, 2022
@MaximeEvrard42 MaximeEvrard42 self-assigned this Feb 11, 2022
@MaximeEvrard42 MaximeEvrard42 mentioned this issue Feb 11, 2022
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MaximeEvrard42 MaximeEvrard42

Labels
A-Timeline T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements Z-Ready This issue is ready for development Z-WTF WTF issues: High impact, Low Effort
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace "kick" by "remove" in all strings element-hq/element-ios
4 participants
@pixlwave @MaximeEvrard42 @gaelledel @daniellekirkwood