Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HomeViewController still shows Favourites/Low Priority sections when removing last room #5448

Closed
pixlwave opened this issue Jan 27, 2022 · 0 comments · Fixed by #5483
Closed

HomeViewController still shows Favourites/Low Priority sections when removing last room #5448

pixlwave opened this issue Jan 27, 2022 · 0 comments · Fixed by #5483
Assignees
@ismailgulek
Labels
A-Room-List O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems

Comments

@pixlwave
Copy link
Member

Steps to reproduce

All steps below for Favourites, but same effect is seen with Low Priority

  1. Start with an account with at least 2 rooms but no favourites.
  2. Long press on a room an favourite it.
  3. Long press on the room in the Favourites section and un-favourite it.

Outcome

What did you expect?

The room to move back to the Rooms section and the Favourites section to be hidden.

What happened instead?

The room moved back to the Rooms section, but the Favourites section remained visible but empty.

Favourites.mov

Your phone model

iPhone 12

Operating system version

iOS 15.2

Application version

Element 1.7.0

Homeserver

No response

Will you send logs?

No
@pixlwave pixlwave added the T-Defect Something isn't working: bugs, crashes, hangs and other reported problems label Jan 27, 2022
@pixlwave pixlwave added A-Room-List O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist labels Jan 27, 2022
@ismailgulek ismailgulek self-assigned this Feb 2, 2022
@ismailgulek ismailgulek mentioned this issue Feb 2, 2022
Merged
ismailgulek added a commit that referenced this issue Feb 2, 2022
@ismailgulek
Reload section if total number of rooms changes, fixes #5448
36f24f3
@ismailgulek ismailgulek mentioned this issue Feb 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ismailgulek ismailgulek

Labels
A-Room-List O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

HomeViewController: Fix empty sections element-hq/element-ios
2 participants
@ismailgulek @pixlwave