Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thread fallback replies are all red #5552

Closed
noantiq opened this issue Feb 11, 2022 · 5 comments · Fixed by #5666
Closed

Thread fallback replies are all red #5552

noantiq opened this issue Feb 11, 2022 · 5 comments · Fixed by #5666
Assignees
Labels
A-Threads Message threading to simplify the Timeline O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems Z-Labs

Comments

@noantiq
Copy link
Contributor

noantiq commented Feb 11, 2022

Steps to reproduce

  1. Do not have threads enabled.
  2. From another account send a message to that room.
  3. From that same account create a thread from that message and send another message in that thread.

Outcome

What did you expect?

Since threads are disabled, the thread reply is simply rendered as a reply.

What happened instead?

The thread reply is rendered as a reply but all of the reply text and the cited message are red. See screenshot below.

5209499E-1FE5-4AEB-A608-FF9621D00144

Your phone model

iPhone 8

Operating system version

iOS 15.3

Application version

Element 1.8.0

Homeserver

Synapse 1.52.0

Will you send logs?

No

@noantiq noantiq added the T-Defect Something isn't working: bugs, crashes, hangs and other reported problems label Feb 11, 2022
@pixlwave pixlwave added A-Threads Message threading to simplify the Timeline O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist labels Feb 11, 2022
@daniellekirkwood
Copy link
Contributor

Hi, @janogarcia Please advise the correct behaviour here

@janogarcia
Copy link

The message shouldn't be highlighted unless there's a user-defined keyword or her name is found in the text. There's nothing particular about threads that should trigger a highlight, the reply fallback should follow the same highlighting rules as regular messages. /cc @ismailgulek


Out of scope but worth mentioning: We should change the mention status for something less visually alarming.

@janogarcia janogarcia assigned ismailgulek and unassigned janogarcia Feb 15, 2022
@janogarcia
Copy link

janogarcia commented Feb 15, 2022

@noantiq Does this also happen with regular, non-loremipsum text? I'm wondering if there's any matching keyword in there that's is the highlight.

@noantiq
Copy link
Contributor Author

noantiq commented Feb 15, 2022

@janogarcia Yes this happens for every message. I made sure there was no keyword triggering it.

I took another screenshot for clarification:
19DD52E4-30CC-4D7C-8DD7-3426FDB9391A

@janogarcia
Copy link

Thanks for confirming and the extra screenshot, noantiq. 👍

@ismailgulek This seems to be a bug. Please make sure that the reply fallback for threads follows the same rule as regular replies for message highlighting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Threads Message threading to simplify the Timeline O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems Z-Labs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants